-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Use set sysroot
for more NDK compatibility
#33848
Conversation
Recent versions of the Android NDK no longer ship debuggers like `arm-linux-androideabi-gdb`, but instead one prebuilt binary `gdb`. We can symlink this into place at least to get our detection still working, but it now needs to be told what the sysroot is so it can correctly do... something. Long story short, tests didn't pass with this change and after this change they pass.
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
This, in combination with #33832 should enable us to move to the r11c NDK and API level 9 for our Android builders |
@bors: r+ |
📌 Commit 0f3e865 has been approved by |
Ok, I've now verified that this plus #33832 gets a green build on Android, bringing improvements like:
I haven't deployed the buildbot changes just yet, and I'm hesitant to do so. These two changes are required and not present on the beta branch, so if we upgrade buildbot we'll be unable to build a new beta compiler (unless we use a different image to build a beta compiler than the nightly compiler. To me, there's a few courses of action to take here:
My preferred course of action is (2) as it's the easiest and probably doesn't have any impact anyway. This change isn't related to the build at all and #33832 should in theory be pretty minor as well. As a result I'm going to beta-nominate this and that, and we can discuss. |
(for those cc'd, see my previous comment) cc @froydnj - going back to API level 9 |
This seems like a reasonable course of action for propagating Android changes sooner. |
Given the minor impact of the changes, backporting seems fine to me. |
In this case, we should also get libc tests going on Android's AArch64. |
…rister test: Use `set sysroot` for more NDK compatibility Recent versions of the Android NDK no longer ship debuggers like `arm-linux-androideabi-gdb`, but instead one prebuilt binary `gdb`. We can symlink this into place at least to get our detection still working, but it now needs to be told what the sysroot is so it can correctly do... something. Long story short, tests didn't pass with this change and after this change they pass.
Recent versions of the Android NDK no longer ship debuggers like
arm-linux-androideabi-gdb
, but instead one prebuilt binarygdb
. We cansymlink this into place at least to get our detection still working, but it now
needs to be told what the sysroot is so it can correctly do... something. Long
story short, tests didn't pass with this change and after this change they pass.