-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #32454
Merged
Merged
Rollup of 11 pull requests #32454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently these aren't supposed to be stored in network byte order, so doing so ends up causing failures when it would otherwise succeed when stored in the host byte order. Closes rust-lang#32424
Const was dereferenced when autoderefs is zero.
I apt to use `expressions` over `statements`, because `match` is a expression in essence, though it can become a statement when followed a semicolon.
…default, r=aturon Implement Default trait for OsString/OsStr Fixes rust-lang#32385
…lexcrichton Add regression test for Issue 26997. rust-lang#26997
…ichton rustdoc: Omit `pub` for inlined variant-struct fields fixes rust-lang#32395 r? @alexcrichton
Added version 7.3* for Apple's clang compiler The recent 7.3 clang version was missing. Closes rust-lang#32442
std: Store flowinfo/scope_id in host byte order Apparently these aren't supposed to be stored in network byte order, so doing so ends up causing failures when it would otherwise succeed when stored in the host byte order. Closes rust-lang#32424
Fix const trans Fix rust-lang#30615. The idea was that when there are N autoderefs, first do N-1 derefs and check for autoref. If there is autoref, done, if not, do one more deref. But when N is zero, doing one more deref is wrong.
… r=steveklabnik Simplifying some of the phrasing explaining lifetime elision Just simplifying some of the language expressing what kind of inference Rust can and can't do on function signatures.
rustdoc: Consider `doc(no_inline)` in crate-local inlining Imports with `doc(no_inline)` will not be inlined, even when `doc(inline)` is present. fixes rust-lang#32343 r? @alexcrichton
Annotate run-pass/backtrace with #[rustc_no_mir] on MSVC. Fixes rust-lang#32384 by not using MIR on MSVC for the functions in the path of the backtrace. This is the known blocker for the MSVC MIR builder, hopefully the only one overall. r? @alexcrichton Confirmed to work on a nightly, by @retep998.
doc: small char improvements
Docs: Change "statements" to "expressions" on `match` I apt to use `expressions` over `statements`, because `match` is a expression in essence, though it can become a statement when followed a semicolon.
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r=eddyb p=1 |
📌 Commit 2e9b40f has been approved by |
This was referenced Mar 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pub
for inlined variant-struct fields #32423, Added version 7.3* for Apple's clang compiler #32425, std: Store flowinfo/scope_id in host byte order #32429, Fix const trans #32430, Simplifying some of the phrasing explaining lifetime elision #32431, rustdoc: Considerdoc(no_inline)
in crate-local inlining #32434, Annotate run-pass/backtrace with #[rustc_no_mir] on MSVC. #32437, doc: small char improvements #32441, Docs: Change "statements" to "expressions" onmatch
#32443