Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added version 7.3* for Apple's clang compiler #32425

Closed
wants to merge 6 commits into from
Closed

Added version 7.3* for Apple's clang compiler #32425

wants to merge 6 commits into from

Conversation

agbaroni
Copy link
Contributor

The recent 7.3 clang version was missing.

Closes #32442

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ 79da64a

@durka durka mentioned this pull request Mar 23, 2016
Closed
@tamird
Copy link
Contributor

tamird commented Mar 23, 2016

Perhaps it's time to allow any 7.x?

@eddyb
Copy link
Member

eddyb commented Mar 23, 2016

@bors rollup

eddyb added a commit to eddyb/rust that referenced this pull request Mar 23, 2016
@eddyb
Rollup merge of rust-lang#32425 - ituxbag:master, r=alexcrichton
0c424f9 
Added version 7.3* for Apple's clang compiler

The recent 7.3 clang version was missing.

Closes rust-lang#32442
@eddyb eddyb mentioned this pull request Mar 23, 2016
Merged
bors added a commit that referenced this pull request Mar 23, 2016
@bors
Auto merge of #32454 - eddyb:rollup, r=eddyb
98f0a91 
Rollup of 11 pull requests

- Successful merges: #32404, #32420, #32423, #32425, #32429, #32430, #32431, #32434, #32437, #32441, #32443
- Failed merges:
@nagisa
Copy link
Member

nagisa commented Mar 25, 2016

The original change seems to have landed through the rollup, but the PR itself seems to have changed in weird ways since rollup was started, thus didn’t get closed automatically.

@nagisa nagisa closed this Mar 25, 2016
@cryon cryon mentioned this pull request Apr 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@agbaroni @rust-highfive @alexcrichton @tamird @eddyb @nagisa