Rollup of 12 pull requests #28769
Merged
Rollup of 12 pull requests #28769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Sep 30, 2015
steveklabnik
commented
- Successful merges: Improve "Variable bindings" chapter #28743, Fix typo in docs: usize is unsigned, not signed #28744, doc: fix typo #28745, path: remove a line of code that is not useful #28749, Fix module links in std::fmt and the Rust book's documentation chapter. #28754, Improve wording in error handling guide #28755, Format panic docs for split_at #28757, Call out slicing syntax more explicitly #28759, Cross-reference doc chapter from testing chapter #28761, Make note of performance implications of Read #28762, Elaborate on the io prelude in the book #28763, Mention that you can only index with usize #28765
- Failed merges:
- Expand the first paragraph - Improve readability by partitioning the chapter into the following sections: "Patterns", "Type annotations", "Mutability", and "Initializing bindings" - Add "Scope and shadowing" section (fix rust-lang#28177)
The links in the rustdoc for several places in fmt were trying to link to the std::fmt module but actually linking to std, which was confusing. While trying to figure out why I noticed that the documentation chapter of the Rust book has examples that show this same bug (although it doesn't seem widespread in practice).
The original blog post referred to examples by their file names, and now that it's in guide form, there is no file name. So edit the text so that it makes a bit more sense. Fixes rust-lang#28428
We don't completely cover documentation tests in the testing chapter, since we cover them in the documentation chapter. So make sure people know that. Fixes rust-lang#28082
- Expand the first paragraph - Improve readability by partitioning the chapter into the following sections: "Patterns", "Type annotations", "Mutability", and "Initializing bindings" - Add "Scope and shadowing" section (fix rust-lang#28177) r? @steveklabnik
…anishearth The links in the rustdoc for several places in fmt were trying to link to the std::fmt module but actually linking to std, which was confusing. While trying to figure out why I noticed that the documentation chapter of the Rust book has examples that show this same bug (although it doesn't seem widespread in practice). r? @steveklabnik
The original blog post referred to examples by their file names, and now that it's in guide form, there is no file name. So edit the text so that it makes a bit more sense. Fixes rust-lang#28428
Fixes rust-lang#28359 I'm not doing more here because it's unclear that `as_slice()` is even going to stick around, see rust-lang#27729
We don't completely cover documentation tests in the testing chapter, since we cover them in the documentation chapter. So make sure people know that. Fixes rust-lang#28082
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit 15ee0e9 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.