Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Clone for Peekable #28738

Merged
merged 1 commit into from
Sep 30, 2015
Merged

Derive Clone for Peekable #28738

merged 1 commit into from
Sep 30, 2015

Conversation

apasel422
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 532ee3c

@bors
Copy link
Contributor

bors commented Sep 30, 2015

⌛ Testing commit 532ee3c with merge 437d70a...

bors added a commit that referenced this pull request Sep 30, 2015
@bors
Auto merge of #28738 - apasel422:peekable, r=alexcrichton
437d70a
@bors
Copy link
Contributor

bors commented Sep 30, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 532ee3c into rust-lang:master Sep 30, 2015
@apasel422 apasel422 deleted the peekable branch September 30, 2015 17:14
@brson brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 30, 2015
@apasel422
Copy link
Contributor Author

@brson Out of curiosity, why did this need relnotes? This was just a simplification of the explicit Clone impl to a derived one.

@brson
Copy link
Contributor

brson commented Oct 8, 2015

@apasel422 Thanks for the clarification. I've removed the tag.

@brson brson removed the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apasel422 @rust-highfive @alexcrichton @bors @brson