Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #27567: remove --crate-type=lib from pretty test #27571

Merged
merged 2 commits into from
Aug 11, 2015
Merged

Fix #27567: remove --crate-type=lib from pretty test #27571

merged 2 commits into from
Aug 11, 2015

Conversation

TimNN
Copy link
Contributor

@TimNN TimNN commented Aug 6, 2015

Because I wanted to change the pretty test as little as possible I added // compiler-flags: --crate-type=lib to those test that failed because of a missing main. Passes make check-stage1-pretty locally.

cc @nrc
cc #27567

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brson
Copy link
Contributor

brson commented Aug 6, 2015

@bors r+ Nice cleanup.

@bors
Copy link
Contributor

bors commented Aug 6, 2015

📌 Commit 9fd0845 has been approved by brson

@bors
Copy link
Contributor

bors commented Aug 6, 2015

⌛ Testing commit 9fd0845 with merge 516a1a3...

@bors
Copy link
Contributor

bors commented Aug 7, 2015

💔 Test failed - auto-linux-32-opt

@TimNN
Copy link
Contributor Author

TimNN commented Aug 7, 2015

So, travis passed and homu failed with an Illegal instruction during compile-fail, which seems to be totally unrelated to any of my changes. Is this just a sporadic failure or is there some action required on my part?

@nrc
Copy link
Member

nrc commented Aug 9, 2015

@bors: retry

@bors
Copy link
Contributor

bors commented Aug 9, 2015

⌛ Testing commit 9fd0845 with merge 3b232d6...

@nrc
Copy link
Member

nrc commented Aug 9, 2015

Travis only runs make tidy so doesn't mean much. The c-fail error could be legit, or perhaps not, we'll see...

@TimNN
Copy link
Contributor Author

TimNN commented Aug 9, 2015

@nrc Since some time ago, travis actually runs make check! https://github.com/rust-lang/rust/blob/master/.travis.yml#L23

@nrc
Copy link
Member

nrc commented Aug 9, 2015

oh, neat!

@bors
Copy link
Contributor

bors commented Aug 9, 2015

💔 Test failed - auto-linux-32-opt

@TimNN
Copy link
Contributor Author

TimNN commented Aug 9, 2015

Looks like #27619

@dotdash
Copy link
Contributor

dotdash commented Aug 10, 2015

@bors retry

@Manishearth Manishearth mentioned this pull request Aug 11, 2015
Merged
bors added a commit that referenced this pull request Aug 11, 2015
@bors
Auto merge of #27658 - Manishearth:rollup, r=Manishearth
c756526 
- Successful merges: #27542, #27571, #27572, #27577, #27611, #27612, #27617, #27633, #27647, #27648, #27651
- Failed merges:
@TimNN
Copy link
Contributor Author

TimNN commented Aug 11, 2015

Seeing as travis passed again, this should be fine now after the fail as part of the rollup (#27658 (comment))

@alexcrichton
Copy link
Member

@bors: r+ f0ea2b6

bors added a commit that referenced this pull request Aug 11, 2015
@bors
Auto merge of #27571 - TimNN:pretty-no-crate-type, r=alexcrichton
dcdcc6f 
Because I wanted to change the pretty test as little as possible I added `// compiler-flags: --crate-type=lib` to those test that failed because of a missing `main`. Passes `make check-stage1-pretty` locally.

cc @nrc
cc #27567
@bors
Copy link
Contributor

bors commented Aug 11, 2015

⌛ Testing commit f0ea2b6 with merge dcdcc6f...

@bors
Copy link
Contributor

bors commented Aug 11, 2015

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Contributor

bors commented Aug 11, 2015

⚡ Previous build results for auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt...

@bors
Copy link
Contributor

bors commented Aug 11, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit f0ea2b6 into rust-lang:master Aug 11, 2015
@TimNN TimNN mentioned this pull request Aug 11, 2015
Merged
@TimNN TimNN deleted the pretty-no-crate-type branch September 6, 2015 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TimNN @rust-highfive @brson @bors @nrc @dotdash @alexcrichton