Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretty test should not specify --crate-type=lib when typechecking #27567

Closed
TimNN opened this issue Aug 6, 2015 · 1 comment
Closed

pretty test should not specify --crate-type=lib when typechecking #27567

TimNN opened this issue Aug 6, 2015 · 1 comment

Comments

@TimNN
Copy link
Contributor

TimNN commented Aug 6, 2015

Since the early days of pretty tests (77be30f) they were compiled as libraries so that they did not require a main function. By now they also run on all the run pass test, which all have a main and there is (or soon will be) at least one run pass test which requires to be compiled as a binary (see #27565).

As discussed shortly on irc (starting here), the best solution seems to be to remove that flag and only add it to those tests which require it.

I'll try to tackle this and get a pull request up soon.

cc @nrc

@TimNN
Copy link
Contributor Author

TimNN commented Aug 11, 2015

Alright, I fixed this pr to account for another pretty test which was added after I first open this pr, it should now build again.

bors added a commit that referenced this issue Aug 11, 2015
Because I wanted to change the pretty test as little as possible I added `// compiler-flags: --crate-type=lib` to those test that failed because of a missing `main`. Passes `make check-stage1-pretty` locally.

cc @nrc
cc #27567
@bors bors closed this as completed in f0ea2b6 Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant