You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since the early days of pretty tests (77be30f) they were compiled as libraries so that they did not require a main function. By now they also run on all the run pass test, which all have a main and there is (or soon will be) at least one run pass test which requires to be compiled as a binary (see #27565).
As discussed shortly on irc (starting here), the best solution seems to be to remove that flag and only add it to those tests which require it.
I'll try to tackle this and get a pull request up soon.
Because I wanted to change the pretty test as little as possible I added `// compiler-flags: --crate-type=lib` to those test that failed because of a missing `main`. Passes `make check-stage1-pretty` locally.
cc @nrc
cc #27567
Since the early days of pretty tests (77be30f) they were compiled as libraries so that they did not require a main function. By now they also run on all the run pass test, which all have a main and there is (or soon will be) at least one run pass test which requires to be compiled as a binary (see #27565).
As discussed shortly on irc (starting here), the best solution seems to be to remove that flag and only add it to those tests which require it.
I'll try to tackle this and get a pull request up soon.
cc @nrc
The text was updated successfully, but these errors were encountered: