-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crashes: add test for #131451 #133104
crashes: add test for #131451 #133104
Conversation
This should be scriptable: First off, try with a lower Build with You should be able to manually enable only the passes that produce a diff in the MIR. The before and after files always differ on the first line because that's a comment that repeats the file's name. Then trim down that list of passes further, if possible. |
ok ty, I think I got it :D ls -c1 | sort -n | grep after | grep -o "...-...\..*.after" | cut -c9- | sed 's/\.after$//g' | sed s/^/\"-Zmir-enable-passes=+/ | sed -e s/$/\",/ Then I throw this into icemaker and let it reduce the flags automatically:
|
Can you drop -Clink-dead-code=true if the fn is pub? |
6fca409
to
159ed85
Compare
@rustbot ready |
Nice! |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#131669 (lint: change help for pointers to dyn types in FFI) - rust-lang#133104 (crashes: add test for rust-lang#131451) - rust-lang#133767 (Add more info on type/trait mismatches for different crate versions) - rust-lang#133861 (Add allocate_bytes and refactor allocate_str in InterpCx for raw byte…) - rust-lang#133976 (Removed Unnecessary Spaces From RELEASES.md) - rust-lang#133987 (Define acronym for thread local storage) - rust-lang#133992 (Actually walk into lifetimes and attrs in `EarlyContextAndPass`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#133104 - matthiaskrgr:crashtest_debugass_131451.rs, r=saethlin crashes: add test for rust-lang#131451 r? `@saethlin` How do I find out which mir opts are involved here? 😅
r? @saethlin
How do I find out which mir opts are involved here? 😅