add some debug-assertion crash tests #132789

matthiaskrgr · 2024-11-08T20:33:59Z

r? ghost

try-job: x86_64-gnu

matthiaskrgr · 2024-11-08T20:38:26Z

@bors try

add some debug-assertion crash tests r? ghost try-job: x86_64-gnu-llvm-18

bors · 2024-11-08T20:39:37Z

⌛ Trying commit b521cae with merge 5b739e4...

matthiaskrgr · 2024-11-08T20:40:33Z

@rustbot author

bors · 2024-11-08T22:58:01Z

☀️ Try build successful - checks-actions
Build commit: 5b739e4 (5b739e404d35520d5ee76f6a553037de34fd6ff0)

tests/crashes/131451.rs

matthiaskrgr · 2024-11-16T12:36:07Z

r? @jieyouxu

tests/crashes/116979.rs

jieyouxu

In any case, I'm inclined to r+ this because crashes tests are easy to remove and helps to detect changes (incl. fixes). Whether to add incomplete_features crashes tests in the future can be discussed separately.

jieyouxu · 2024-11-16T12:54:31Z

@bors r+ rollup=iffy

bors · 2024-11-16T12:54:33Z

📌 Commit 3a2c247 has been approved by jieyouxu

It is now in the queue for this repository.

add some debug-assertion crash tests r? ghost try-job: x86_64-gnu-llvm-18

bors · 2024-11-16T13:17:12Z

⌛ Testing commit 3a2c247 with merge 964b99f...

bors · 2024-11-16T13:36:13Z

💔 Test failed - checks-actions

jieyouxu · 2024-11-17T08:26:20Z

Hm, that's weird... Is the directive implementation wrong I wonder

EDIT: I'm missing something because this passes locally and is ignored when rustc built without debug assertions as I expected.

cc https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/When.20is.20rustc.20built.20with.20debug.20assertions.3F

jieyouxu · 2024-11-17T10:10:10Z

It doesn't even fail locally in x86_64-gnu, I'm missing something

jieyouxu · 2024-11-17T10:24:59Z

@bors try

add some debug-assertion crash tests r? ghost try-job: x86_64-gnu

bors · 2024-11-17T10:26:09Z

⌛ Trying commit 3a2c247 with merge 0bc8c97...

bors · 2024-12-09T06:11:08Z

⌛ Testing commit 716d99c with merge 3cf0a6c...

add some debug-assertion crash tests r? ghost try-job: x86_64-gnu

rust-log-analyzer · 2024-12-09T07:11:25Z

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[2024-12-09T07:02:56Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-12-09T07:02:56Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-12-09T07:02:56Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpdJYjQe#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln"
[2024-12-09T07:02:59Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2024-12-09T07:02:59Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpdJYjQe#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpdJYjQe\\incremental-state"
[2024-12-09T07:03:03Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2024-12-09T07:03:03Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpdJYjQe#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpdJYjQe\\incremental-state"
[2024-12-09T07:03:04Z DEBUG collector::compile::benchmark::patch] applying new row to "C:\\a\\_temp\\msys64\\tmp\\.tmpdJYjQe"
[2024-12-09T07:03:04Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("new row"), path: "0-new-row.patch" }), backend=Llvm, phase=benchmark
[2024-12-09T07:03:04Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("new row"), path: "0-new-row.patch" }), backend=Llvm, phase=benchmark
[2024-12-09T07:03:04Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpdJYjQe#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpdJYjQe\\incremental-state"
##[endgroup]
[2024-12-09T07:03:08.024Z INFO  opt_dist::training] Merging Rustc PGO profiles to C:\a\rust\rust\opt-artifacts\rustc-pgo.profdata
[2024-12-09T07:03:08.024Z INFO  opt_dist::exec] Executing `C:\a\rust\rust\build\x86_64-pc-windows-msvc\llvm\build\bin/llvm-profdata.exe merge -o C:\a\rust\rust\opt-artifacts\rustc-pgo.profdata C:\a\rust\rust\opt-artifacts\rustc-pgo [at C:\a\rust\rust]`
[2024-12-09T07:03:25.721Z INFO  opt_dist::training] Rustc PGO statistics
---
   Compiling rustc_driver v0.0.0 (C:\a\rust\rust\compiler\rustc_driver)
[RUSTC-TIMING] rustc_driver test:false 5.040
error: linking with `link.exe` failed: exit code: 1104
  |
  = note: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\bin\\HostX64\\x64\\link.exe" "/NOLOGO" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\symbols.o" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\deps\\rustc_main-ff7d3adfdb67a118.rustc_main.576a6dcf1efc16ae-cgu.0.rcgu.o" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\deps\\rustc_driver-845e4872cc016b83.dll.lib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-c25bba97e86b102c.rlib" "psapi.lib" "shell32.lib" "ole32.lib" "uuid.lib" "advapi32.lib" "ws2_32.lib" "ntdll.lib" "kernel32.lib" "advapi32.lib" "ole32.lib" "oleaut32.lib" "advapi32.lib" "cfgmgr32.lib" "gdi32.lib" "kernel32.lib" "msimg32.lib" "opengl32.lib" "user32.lib" "winspool.lib" "bcrypt.lib" "advapi32.lib" "legacy_stdio_definitions.lib" "kernel32.lib" "kernel32.lib" "advapi32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "dbghelp.lib" "/defaultlib:libcmt" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\advapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-errorhandling-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-file-fromapp-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-handle-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-ioring-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-memory-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-memory-l1-1-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-memory-l1-1-5.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-memory-l1-1-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-memory-l1-1-7.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-memory-l1-1-8.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-synch-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-sysinfo-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-sysinfo-l1-2-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-sysinfo-l1-2-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-sysinfo-l1-2-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-util-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-winrt-error-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-winrt-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-core-wow64-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\api-ms-win-security-base-l1-2-2.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\avrt.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\bcp47mrm.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\bcryptprimitives.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\clfsw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\dbghelp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\elscore.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\gdi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\icu.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\imagehlp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\kernel32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\ktmw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\netapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\normaliz.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\ntdll.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\ntdllk.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\ole32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\oleacc.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\oleaut32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\propsys.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\psapi.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\rtworkq.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\txfw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\user32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\usp10.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\version.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcVFTJf5\\wofutil.dll_imports_indirect.lib" "/NXCOMPAT" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\stacker-51665ada3368c7c5\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\psm-49e517f07a604d4e\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\blake3-40658902d69c9924\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\blake3-40658902d69c9924\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\rustc_llvm-2e0139d76762918c\\out" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\llvm\\lib" "/OUT:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\deps\\rustc_main-ff7d3adfdb67a118.exe" "/OPT:REF,ICF" "/DEBUG" "/PDBALTPATH:%_PDB%" "/MANIFEST:EMBED" "/MANIFESTINPUT:C:\\a\\rust\\rust\\compiler\\rustc\\Windows Manifest.xml" "/WX"
  = note: LINK : fatal error LNK1104: cannot open file 'C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\rustc_main-ff7d3adfdb67a118.exe'␍

[RUSTC-TIMING] rustc_main test:false 0.654
error: could not compile `rustc-main` (bin "rustc-main") due to 1 previous error
Build completed unsuccessfully in 0:07:40

bors · 2024-12-09T07:12:04Z

💔 Test failed - checks-actions

jieyouxu · 2024-12-09T07:18:54Z

@bors retry (msvc take 2)

add some debug-assertion crash tests r? ghost try-job: x86_64-gnu

Rollup of 5 pull requests Successful merges: - rust-lang#128004 (codegen `#[naked]` functions using global asm) - rust-lang#132789 (add some debug-assertion crash tests) - rust-lang#133456 (Add licenses + Run `cargo update`) - rust-lang#133853 (use vendor sources by default on dist tarballs) - rust-lang#133902 (CI: move `dist-arm-linux` to an ARM runner) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-12-09T21:49:47Z

⌛ Testing commit 716d99c with merge f70c5a7...

add some debug-assertion crash tests r? ghost try-job: x86_64-gnu

rust-log-analyzer · 2024-12-10T00:05:06Z

The job i686-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_driver v0.0.0 (C:\a\rust\rust\compiler\rustc_driver)
[RUSTC-TIMING] rustc_driver test:false 27.835
error: linking with `i686-w64-mingw32-gcc` failed: exit code: 1
  |
  = note: "i686-w64-mingw32-gcc" "-fno-use-linker-plugin" "-Wl,--dynamicbase" "-Wl,--disable-auto-image-base" "-Wl,--large-address-aware" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsbegin.o" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\symbols.o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_main-9d8793ca139200e4.rustc_main.e5fe66732361acd4-cgu.0.rcgu.o" "-Wl,-Bdynamic" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_driver-d16fcb59460a733f.dll" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\std-85e8e1afc0a1e2c0.dll" "-Wl,-Bstatic" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\libcompiler_builtins-d77c9d76f065957b.rlib" "-Wl,-Bdynamic" "-lpsapi" "-lshell32" "-lole32" "-luuid" "-ladvapi32" "-lws2_32" "-lntdll" "-lkernel32" "-ladvapi32" "-lole32" "-loleaut32" "-ladvapi32" "-lcfgmgr32" "-lgdi32" "-lkernel32" "-lmsimg32" "-lopengl32" "-luser32" "-lwinspool" "-lbcrypt" "-ladvapi32" "-lkernel32" "-lkernel32" "-ladvapi32" "-lntdll" "-luserenv" "-lws2_32" "-ldbghelp" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\advapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-errorhandling-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-file-fromapp-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-handle-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-ioring-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-memory-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-memory-l1-1-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-memory-l1-1-5.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-memory-l1-1-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-memory-l1-1-7.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-memory-l1-1-8.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-synch-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-sysinfo-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-sysinfo-l1-2-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-sysinfo-l1-2-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-sysinfo-l1-2-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-util-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-winrt-error-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-winrt-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-core-wow64-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\api-ms-win-security-base-l1-2-2.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\avrt.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\bcp47mrm.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\bcryptprimitives.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\clfsw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\dbghelp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\elscore.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\gdi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\icu.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\imagehlp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\kernel32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\ktmw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\netapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\normaliz.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\ntdll.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\ntdllk.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\ole32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\oleacc.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\oleaut32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\propsys.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\psapi.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\rtworkq.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\txfw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\user32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\usp10.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\version.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcufcv0h\\wofutil.dll_imports_indirect.lib" "-lgcc_s" "-lmsvcrt" "-lmingwex" "-lmingw32" "-lgcc" "-lmsvcrt" "-lmingwex" "-luser32" "-lkernel32" "-Wl,--nxcompat" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\stacker-d3f5f2020a9db92d\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\psm-a8e1851838120981\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\blake3-a0d1954ccec93ff8\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\rustc_llvm-9c1d12dc9076cada\\out" "-L" "C:/a/rust/rust/build/i686-pc-windows-gnu/llvm/lib" "-L" "C:/a/rust/rust/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.1.0" "-o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_main-9d8793ca139200e4.exe" "-Wl,--gc-sections" "-no-pie" "-Wl,-O1" "-nodefaultlibs" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsend.o"
  = note: C:/a/rust/rust/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.1.0/../../../../i686-w64-mingw32/bin/ld.exe: cannot open output file C:\a\rust\rust\build\i686-pc-windows-gnu\stage1-rustc\i686-pc-windows-gnu\release\deps\rustc_main-9d8793ca139200e4.exe: Invalid argument␍
          collect2.exe: error: ld returned 1 exit status

[RUSTC-TIMING] rustc_main test:false 3.918
error: could not compile `rustc-main` (bin "rustc-main") due to 1 previous error
Build completed unsuccessfully in 0:33:21

bors · 2024-12-10T00:05:53Z

💔 Test failed - checks-actions

jieyouxu · 2024-12-11T05:58:52Z

Really...
@bors retry (mingw)

bors · 2024-12-12T16:08:11Z

⌛ Testing commit 716d99c with merge a94fce9...

bors · 2024-12-12T18:52:24Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing a94fce9 to master...

rust-timer · 2024-12-12T20:10:17Z

Finished benchmarking commit (a94fce9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.0%	[-2.0%, -2.0%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.396s -> 771.536s (0.02%)
Artifact size: 330.93 MiB -> 331.05 MiB (0.03%)

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 8, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 8, 2024

Auto merge of rust-lang#132789 - matthiaskrgr:debug_tests, r=<try>

5b739e4

add some debug-assertion crash tests r? ghost try-job: x86_64-gnu-llvm-18

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2024

saethlin reviewed Nov 8, 2024

View reviewed changes

tests/crashes/131451.rs Outdated Show resolved Hide resolved

matthiaskrgr marked this pull request as ready for review November 16, 2024 12:35

rustbot assigned jieyouxu Nov 16, 2024

matthiaskrgr force-pushed the debug_tests branch from b521cae to 3a2c247 Compare November 16, 2024 12:36

jieyouxu reviewed Nov 16, 2024

View reviewed changes

tests/crashes/116979.rs Show resolved Hide resolved

jieyouxu approved these changes Nov 16, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 16, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2024

Auto merge of rust-lang#132789 - matthiaskrgr:debug_tests, r=jieyouxu

964b99f

add some debug-assertion crash tests r? ghost try-job: x86_64-gnu-llvm-18

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 16, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2024

Auto merge of rust-lang#132789 - matthiaskrgr:debug_tests, r=<try>

0bc8c97

add some debug-assertion crash tests r? ghost try-job: x86_64-gnu

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 9, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2024

Auto merge of rust-lang#132789 - matthiaskrgr:debug_tests, r=jieyouxu

3cf0a6c

add some debug-assertion crash tests r? ghost try-job: x86_64-gnu

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 9, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2024

jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 9, 2024

Rollup merge of rust-lang#132789 - matthiaskrgr:debug_tests, r=jieyouxu

6264f53

add some debug-assertion crash tests r? ghost try-job: x86_64-gnu

jieyouxu mentioned this pull request Dec 9, 2024

Rollup of 5 pull requests #134069

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2024

Auto merge of rust-lang#132789 - matthiaskrgr:debug_tests, r=jieyouxu

f70c5a7

add some debug-assertion crash tests r? ghost try-job: x86_64-gnu

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 10, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2024

This was referenced Dec 12, 2024

Add lint rule for #[deprecated] on re-exports #132038

Open

Fix powerpc64 big-endian FreeBSD ABI #132150

Open

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 12, 2024

bors merged commit a94fce9 into rust-lang:master Dec 12, 2024
8 of 13 checks passed

rustbot added this to the 1.85.0 milestone Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add some debug-assertion crash tests #132789

add some debug-assertion crash tests #132789

matthiaskrgr commented Nov 8, 2024 •

edited by jieyouxu

Loading

matthiaskrgr commented Nov 8, 2024

bors commented Nov 8, 2024

matthiaskrgr commented Nov 8, 2024

bors commented Nov 8, 2024

matthiaskrgr commented Nov 16, 2024

jieyouxu left a comment •

edited

Loading

jieyouxu commented Nov 16, 2024

bors commented Nov 16, 2024

bors commented Nov 16, 2024

This comment has been minimized.

bors commented Nov 16, 2024

jieyouxu commented Nov 17, 2024 •

edited

Loading

jieyouxu commented Nov 17, 2024

jieyouxu commented Nov 17, 2024

bors commented Nov 17, 2024

bors commented Dec 9, 2024

rust-log-analyzer commented Dec 9, 2024

bors commented Dec 9, 2024

jieyouxu commented Dec 9, 2024

bors commented Dec 9, 2024

rust-log-analyzer commented Dec 10, 2024

bors commented Dec 10, 2024

jieyouxu commented Dec 11, 2024

bors commented Dec 12, 2024

bors commented Dec 12, 2024

rust-timer commented Dec 12, 2024

add some debug-assertion crash tests #132789

add some debug-assertion crash tests #132789

Conversation

matthiaskrgr commented Nov 8, 2024 • edited by jieyouxu Loading

matthiaskrgr commented Nov 8, 2024

bors commented Nov 8, 2024

matthiaskrgr commented Nov 8, 2024

bors commented Nov 8, 2024

matthiaskrgr commented Nov 16, 2024

jieyouxu left a comment • edited Loading

Choose a reason for hiding this comment

jieyouxu commented Nov 16, 2024

bors commented Nov 16, 2024

bors commented Nov 16, 2024

This comment has been minimized.

bors commented Nov 16, 2024

jieyouxu commented Nov 17, 2024 • edited Loading

jieyouxu commented Nov 17, 2024

jieyouxu commented Nov 17, 2024

bors commented Nov 17, 2024

bors commented Dec 9, 2024

rust-log-analyzer commented Dec 9, 2024

bors commented Dec 9, 2024

jieyouxu commented Dec 9, 2024

bors commented Dec 9, 2024

rust-log-analyzer commented Dec 10, 2024

bors commented Dec 10, 2024

jieyouxu commented Dec 11, 2024

bors commented Dec 12, 2024

bors commented Dec 12, 2024

rust-timer commented Dec 12, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

matthiaskrgr commented Nov 8, 2024 •

edited by jieyouxu

Loading

jieyouxu left a comment •

edited

Loading

jieyouxu commented Nov 17, 2024 •

edited

Loading