fix coherence error for very large tuples™ #132001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
| // causing a coherence error in diesel, see #131969. We still bail with verflow | ||
| // when later returning from the parent AliasRelate goal. | ||
| if !self.is_normalizes_to_goal { | ||
| let num_non_region_vars = canonical.variables.iter().filter(|c| !c.is_region()).count(); |
There was a problem hiding this comment.
Suggested change
| let num_non_region_vars = canonical.variables.iter().filter(|c| !c.is_region()).count(); | |
| let num_non_region_vars = canonical.variables.iter().filter(|c| !c.is_region() && !c.is_existential()).count(); |
|
@bors r=compiler-errors rollup |
bors
added
S-waiting-on-bors
Noratrieb
reviewed
Oct 21, 2024
| // | ||
| // We don't do so for `NormalizesTo` goals as we erased the expected term and | ||
| // bailing with overflow here would prevent us from detecting a type-mismatch, | ||
| // causing a coherence error in diesel, see #131969. We still bail with verflow |
There was a problem hiding this comment.
Suggested change
| // causing a coherence error in diesel, see #131969. We still bail with verflow | |
| // causing a coherence error in diesel, see #131969. We still bail with overflow |
(i won't r-, you can if you want to or not)
There was a problem hiding this comment.
verflow is actually a type-system specific concept :clueless:
There was a problem hiding this comment.
ah i see, it describes the way crates of different versions flow through the type system
There was a problem hiding this comment.
fixed as part of #132026 :3
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 21, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#130350 (stabilize Strict Provenance and Exposed Provenance APIs) - rust-lang#131737 (linkchecker: add a reminder on broken links to add new/renamed pages to `SUMMARY.md` for mdBooks) - rust-lang#131991 (test: Add test for trait in FQS cast, issue rust-lang#98565) - rust-lang#131997 (Make `rustc_abi` compile on stable again) - rust-lang#131999 (Improve test coverage for `unit_bindings` lint) - rust-lang#132001 (fix coherence error for very large tuples™) - rust-lang#132003 (update ABI compatibility docs for new option-like rules) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 21, 2024
Rollup merge of rust-lang#132001 - lcnr:stabilize-coherence-again, r=compiler-errors fix coherence error for very large tuples™ see https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/diesel.20error for an in-depth explanation of this issue. We once again specialize `NormalizesTo` goals to avoid the impact of erasing their expected term. fixes rust-lang#131969 r? `@compiler-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://rust-lang.zulipchat.com/#narrow/channel/364551-t-types.2Ftrait-system-refactor/topic/diesel.20error for an in-depth explanation of this issue. We once again specialize
NormalizesTogoals to avoid the impact of erasing their expected term.fixes #131969
r? @compiler-errors