Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rustc_abi compile on stable again #131997

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Make rustc_abi compile on stable again #131997

merged 2 commits into from
Oct 21, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Oct 21, 2024

#131473 accidentally broke this

@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2024

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Veykril Veykril changed the title Make rustc_abi compile on stable again Make rustc_abi compile on stable again Oct 21, 2024
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 21, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@jieyouxu
Copy link
Member

jieyouxu commented Oct 21, 2024 •
edited
Loading

I feel like we ought to have something try to build the intended-to-be-stable crates as, well, stable, in full CI, but alas nevermind the test is exactly doing that, don't mind me

jieyouxu
jieyouxu approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me, feel free to r=me after PR CI is green.

@jieyouxu jieyouxu assigned jieyouxu and unassigned wesleywiser Oct 21, 2024
@lqd lqd mentioned this pull request Oct 21, 2024
Open
@jieyouxu
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 21, 2024

📌 Commit c7e6f1c has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 21, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 21, 2024
@bors
Auto merge of rust-lang#132005 - matthiaskrgr:rollup-ced4upi, r=matth…
31e102c 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#130350 (stabilize Strict Provenance and Exposed Provenance APIs)
 - rust-lang#131737 (linkchecker: add a reminder on broken links to add new/renamed pages to `SUMMARY.md` for mdBooks)
 - rust-lang#131991 (test: Add test for trait in FQS cast, issue rust-lang#98565)
 - rust-lang#131997 (Make `rustc_abi` compile on stable again)
 - rust-lang#131999 (Improve test coverage for `unit_bindings` lint)
 - rust-lang#132001 (fix coherence error for very large tuples™)
 - rust-lang#132003 (update ABI compatibility docs for new option-like rules)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d0c8d3e into rust-lang:master Oct 21, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 21, 2024
@rust-timer
Unrolled build for rust-lang#131997
9f59e0f 
Rollup merge of rust-lang#131997 - Veykril:veykril/push-upvqkyxmvkzw, r=jieyouxu

Make `rustc_abi` compile on stable again

rust-lang#131473 accidentally broke this
@Veykril Veykril deleted the veykril/push-upvqkyxmvkzw branch October 22, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Veykril @rustbot @jieyouxu @bors @wesleywiser