Stabilize s390x inline assembly #131258

taiki-e · 2024-10-04T16:08:27Z

This stabilizes inline assembly for s390x (SystemZ).

Corresponding reference PR: rust-lang/reference#1643

From the requirements of stabilization mentioned in #93335

Each architecture needs to be reviewed before stabilization:

It must have clobber_abi.

Done in #130630.

It must be possible to clobber every register that is normally clobbered by a function call.

Done in the PR that added support for clobber_abi.

Generally review that the exposed register classes make sense.

The followings can be used as input/output:

reg (r[0-10], r[12-14]): General-purpose register
reg_addr (r[1-10], r[12-14]): General-purpose register except r0 which is evaluated as zero in an address context

This class is needed because r0, which may be allocated when using the reg class, cannot be used as a register in certain contexts. This is identical to the a constraint in LLVM and GCC. See Support reg_addr register class in s390x inline assembly #119431 for details.
freg (f[0-15]): Floating-point register

The followings are clobber-only:

vreg (v[0-31]): Vector register

Technically vreg should be able to accept #[repr(simd)] types as input/output if the unstable vector target feature added is enabled, but core::arch has no s390x vector type and both #[repr(simd)] and core::simd are unstable. Everything related is unstable, so the fact that this is currently a clobber-only should not be considered a stabilization blocker. (s390x vector facilities support #130869 tracks unstable stuff here)
areg (a[2-15]): Access register

All of the above register classes except reg_addr are needed for clobber_abi.

The followings cannot be used as operands for inline asm (see also getReservedRegs and SystemZELFRegisters in LLVM):

r11: frame pointer
r15: stack pointer
a0, a1: Reserved for system use
c[0-15] (control register) Reserved by the kernel

Although not listed in the above requirements, preserves_flags is implemented in #111331.

cc @uweigand

r? @Amanieu

@rustbot label +O-SystemZ +A-inline-assembly

Amanieu · 2024-10-04T16:53:44Z

LGTM, but stabilization needs a T-lang FCP.

taiki-e · 2024-10-13T07:32:27Z

r? lang for FCP

workingjubilee · 2024-10-26T19:24:10Z

@taiki-e

The followings are clobber-only:

vreg (v[0-31]): Vector register

Technically vreg should be able to accept #[repr(simd)] types as input/output if the unstable vector target feature added is enabled, but core::arch has no s390x vector type and both #[repr(simd)] and core::simd are unstable. Everything related is unstable, so the fact that this is currently a clobber-only should not be considered a stabilization blocker. (#130869 tracks unstable stuff here)

Just to confirm: this is mostly a fairly ordinary "packed SIMD" ISA extension, right? The registers at least are not some exotic ambiguously-sized vector like RISCV's V or AArch64's SVE, but instead have some known fixed size?

tgross35 · 2024-10-26T19:46:29Z

Per #131781 (comment):

@rustbot labels +I-lang-nominated

taiki-e · 2024-10-26T19:49:21Z

@workingjubilee

Just to confirm: this is mostly a fairly ordinary "packed SIMD" ISA extension, right?

Yes. s390x vector facility is fixed-size (packed) SIMD ISA and each vector register is 128 bits long.

joshtriplett · 2024-10-30T15:52:59Z

@rfcbot merge

rfcbot · 2024-10-30T15:53:02Z

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

traviscross · 2024-10-30T15:55:47Z

@rfcbot reviewed

nikomatsakis · 2024-10-30T15:57:04Z

Glad to see the reference PR as well. I feel good about this. I agree with the general point that it would be good to have a group of people actively maintaining this architecture who can look this over and vet it, but that has more to do with the requirements to be Tier 2 than anything specific to this PR.

@rfcbot required

bors · 2024-11-02T01:08:28Z

☔ The latest upstream changes (presumably #132470) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2024-11-05T06:32:38Z

☔ The latest upstream changes (presumably #131341) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2024-11-08T00:15:26Z

☔ The latest upstream changes (presumably #132472) made this pull request unmergeable. Please resolve the merge conflicts.

rfcbot · 2024-11-09T16:00:01Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

taiki-e · 2024-11-09T19:49:12Z

@rustbot label -S-waiting-on-team

Amanieu · 2024-11-09T21:23:17Z

@bors r+

bors · 2024-11-09T21:23:20Z

📌 Commit ab62a35 has been approved by Amanieu

It is now in the queue for this repository.

…nieu Stabilize s390x inline assembly This stabilizes inline assembly for s390x (SystemZ). Corresponding reference PR: rust-lang/reference#1643 --- From the requirements of stabilization mentioned in rust-lang#93335 > Each architecture needs to be reviewed before stabilization: > - It must have clobber_abi. Done in rust-lang#130630. > - It must be possible to clobber every register that is normally clobbered by a function call. Done in the PR that added support for clobber_abi. > - Generally review that the exposed register classes make sense. The followings can be used as input/output: - `reg` (`r[0-10]`, `r[12-14]`): General-purpose register - `reg_addr` (`r[1-10]`, `r[12-14]`): General-purpose register except `r0` which is evaluated as zero in an address context This class is needed because `r0`, which may be allocated when using the `reg` class, cannot be used as a register in certain contexts. This is identical to the `a` constraint in LLVM and GCC. See rust-lang#119431 for details. - `freg` (`f[0-15]`): Floating-point register The followings are clobber-only: - `vreg` (`v[0-31]`): Vector register Technically `vreg` should be able to accept `#[repr(simd)]` types as input/output if the unstable `vector` target feature added is enabled, but `core::arch` has no s390x vector type and both `#[repr(simd)]` and `core::simd` are unstable. Everything related is unstable, so the fact that this is currently a clobber-only should not be considered a stabilization blocker. (rust-lang#130869 tracks unstable stuff here) - `areg` (`a[2-15]`): Access register All of the above register classes except `reg_addr` are needed for `clobber_abi`. The followings cannot be used as operands for inline asm (see also [getReservedRegs](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/SystemZ/SystemZRegisterInfo.cpp#L258-L282) and [SystemZELFRegisters](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/SystemZ/SystemZRegisterInfo.h#L107-L128) in LLVM): - `r11`: frame pointer - `r15`: stack pointer - `a0`, `a1`: Reserved for system use - `c[0-15]` (control register) Reserved by the kernel Although not listed in the above requirements, `preserves_flags` is implemented in rust-lang#111331. --- cc `@uweigand` r? `@Amanieu` `@rustbot` label +O-SystemZ +A-inline-assembly

…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#131258 (Stabilize s390x inline assembly) - rust-lang#132577 (Report the `unexpected_cfgs` lint in external macros) - rust-lang#132801 (interpret: get_alloc_info: also return mutability) - rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage) r? `@ghost` `@rustbot` modify labels: rollup

…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#131258 (Stabilize s390x inline assembly) - rust-lang#132801 (interpret: get_alloc_info: also return mutability) - rust-lang#132823 (require const_impl_trait gate for all conditional and trait const calls) - rust-lang#132824 (Update grammar in wasm-c-abi's compiler flag documentation) - rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage) - rust-lang#132828 (Additional tests to ensure let is rejected during parsing) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-11-10T08:15:47Z

⌛ Testing commit ab62a35 with merge 6689597...

Rollup merge of rust-lang#131258 - taiki-e:s390x-stabilize-asm, r=Amanieu Stabilize s390x inline assembly This stabilizes inline assembly for s390x (SystemZ). Corresponding reference PR: rust-lang/reference#1643 --- From the requirements of stabilization mentioned in rust-lang#93335 > Each architecture needs to be reviewed before stabilization: > - It must have clobber_abi. Done in rust-lang#130630. > - It must be possible to clobber every register that is normally clobbered by a function call. Done in the PR that added support for clobber_abi. > - Generally review that the exposed register classes make sense. The followings can be used as input/output: - `reg` (`r[0-10]`, `r[12-14]`): General-purpose register - `reg_addr` (`r[1-10]`, `r[12-14]`): General-purpose register except `r0` which is evaluated as zero in an address context This class is needed because `r0`, which may be allocated when using the `reg` class, cannot be used as a register in certain contexts. This is identical to the `a` constraint in LLVM and GCC. See rust-lang#119431 for details. - `freg` (`f[0-15]`): Floating-point register The followings are clobber-only: - `vreg` (`v[0-31]`): Vector register Technically `vreg` should be able to accept `#[repr(simd)]` types as input/output if the unstable `vector` target feature added is enabled, but `core::arch` has no s390x vector type and both `#[repr(simd)]` and `core::simd` are unstable. Everything related is unstable, so the fact that this is currently a clobber-only should not be considered a stabilization blocker. (rust-lang#130869 tracks unstable stuff here) - `areg` (`a[2-15]`): Access register All of the above register classes except `reg_addr` are needed for `clobber_abi`. The followings cannot be used as operands for inline asm (see also [getReservedRegs](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/SystemZ/SystemZRegisterInfo.cpp#L258-L282) and [SystemZELFRegisters](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/SystemZ/SystemZRegisterInfo.h#L107-L128) in LLVM): - `r11`: frame pointer - `r15`: stack pointer - `a0`, `a1`: Reserved for system use - `c[0-15]` (control register) Reserved by the kernel Although not listed in the above requirements, `preserves_flags` is implemented in rust-lang#111331. --- cc ``@uweigand`` r? ``@Amanieu`` ``@rustbot`` label +O-SystemZ +A-inline-assembly

…nieu Stabilize s390x inline assembly This stabilizes inline assembly for s390x (SystemZ). Corresponding reference PR: rust-lang/reference#1643 --- From the requirements of stabilization mentioned in rust-lang#93335 > Each architecture needs to be reviewed before stabilization: > - It must have clobber_abi. Done in rust-lang#130630. > - It must be possible to clobber every register that is normally clobbered by a function call. Done in the PR that added support for clobber_abi. > - Generally review that the exposed register classes make sense. The followings can be used as input/output: - `reg` (`r[0-10]`, `r[12-14]`): General-purpose register - `reg_addr` (`r[1-10]`, `r[12-14]`): General-purpose register except `r0` which is evaluated as zero in an address context This class is needed because `r0`, which may be allocated when using the `reg` class, cannot be used as a register in certain contexts. This is identical to the `a` constraint in LLVM and GCC. See rust-lang#119431 for details. - `freg` (`f[0-15]`): Floating-point register The followings are clobber-only: - `vreg` (`v[0-31]`): Vector register Technically `vreg` should be able to accept `#[repr(simd)]` types as input/output if the unstable `vector` target feature added is enabled, but `core::arch` has no s390x vector type and both `#[repr(simd)]` and `core::simd` are unstable. Everything related is unstable, so the fact that this is currently a clobber-only should not be considered a stabilization blocker. (rust-lang#130869 tracks unstable stuff here) - `areg` (`a[2-15]`): Access register All of the above register classes except `reg_addr` are needed for `clobber_abi`. The followings cannot be used as operands for inline asm (see also [getReservedRegs](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/SystemZ/SystemZRegisterInfo.cpp#L258-L282) and [SystemZELFRegisters](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/SystemZ/SystemZRegisterInfo.h#L107-L128) in LLVM): - `r11`: frame pointer - `r15`: stack pointer - `a0`, `a1`: Reserved for system use - `c[0-15]` (control register) Reserved by the kernel Although not listed in the above requirements, `preserves_flags` is implemented in rust-lang#111331. --- cc ``@uweigand`` r? ``@Amanieu`` ``@rustbot`` label +O-SystemZ +A-inline-assembly

…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#131258 (Stabilize s390x inline assembly) - rust-lang#132801 (interpret: get_alloc_info: also return mutability) - rust-lang#132823 (require const_impl_trait gate for all conditional and trait const calls) - rust-lang#132824 (Update grammar in wasm-c-abi's compiler flag documentation) - rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage) - rust-lang#132828 (Additional tests to ensure let is rejected during parsing) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Amanieu Oct 4, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. O-SystemZ Target: SystemZ processors (s390x) labels Oct 4, 2024

This was referenced Oct 4, 2024

Add s390x to inline-assembly documentation rust-lang/reference#1643

Merged

s390x linux_raw support bytecodealliance/rustix#1179

Merged

s390x vector facilities support #130869

Open

tgross35 mentioned this pull request Sep 28, 2024

Tracking Issue for asm_experimental_arch #93335

Open

This comment was marked as resolved.

Sign in to view

rustbot added needs-fcp This change is insta-stable, so needs a completed FCP to proceed. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Oct 9, 2024

rustbot assigned pnkfelix and unassigned Amanieu Oct 13, 2024

rustbot added the A-inline-assembly Area: Inline assembly (`asm!(…)`) label Oct 13, 2024

taiki-e mentioned this pull request Oct 16, 2024

Stabilize Arm64EC inline assembly #131781

Merged

rustbot added the I-lang-nominated Nominated for discussion during a lang team meeting. label Oct 26, 2024

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Oct 30, 2024

taiki-e force-pushed the s390x-stabilize-asm branch from 0930d7a to d85d4db Compare November 2, 2024 04:08

taiki-e force-pushed the s390x-stabilize-asm branch from d85d4db to a32d4bc Compare November 5, 2024 12:04

Stabilize s390x inline assembly

ab62a35

taiki-e force-pushed the s390x-stabilize-asm branch from a32d4bc to ab62a35 Compare November 8, 2024 01:46

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Nov 9, 2024

rustbot mentioned this pull request Nov 9, 2024

Tracking issue for release notes of #131258: Stabilize s390x inline assembly #132812

Open

3 tasks

rustbot removed the S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). label Nov 9, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2024

matthiaskrgr mentioned this pull request Nov 9, 2024

Rollup of 4 pull requests #132827

Closed

workingjubilee mentioned this pull request Nov 10, 2024

Rollup of 6 pull requests #132831

Merged

bors merged commit 2f98dcf into rust-lang:master Nov 10, 2024
6 checks passed

rustbot added this to the 1.84.0 milestone Nov 10, 2024

taiki-e deleted the s390x-stabilize-asm branch November 10, 2024 08:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize s390x inline assembly #131258

Stabilize s390x inline assembly #131258

taiki-e commented Oct 4, 2024 •

edited

Loading

Amanieu commented Oct 4, 2024

This comment was marked as resolved.

taiki-e commented Oct 13, 2024

workingjubilee commented Oct 26, 2024 •

edited

Loading

tgross35 commented Oct 26, 2024

taiki-e commented Oct 26, 2024 •

edited

Loading

joshtriplett commented Oct 30, 2024

rfcbot commented Oct 30, 2024 •

edited

Loading

traviscross commented Oct 30, 2024

nikomatsakis commented Oct 30, 2024

bors commented Nov 2, 2024

bors commented Nov 5, 2024

bors commented Nov 8, 2024

rfcbot commented Nov 9, 2024

taiki-e commented Nov 9, 2024

Amanieu commented Nov 9, 2024

bors commented Nov 9, 2024

bors commented Nov 10, 2024

Stabilize s390x inline assembly #131258

Stabilize s390x inline assembly #131258

Conversation

taiki-e commented Oct 4, 2024 • edited Loading

Amanieu commented Oct 4, 2024

This comment was marked as resolved.

taiki-e commented Oct 13, 2024

workingjubilee commented Oct 26, 2024 • edited Loading

tgross35 commented Oct 26, 2024

taiki-e commented Oct 26, 2024 • edited Loading

joshtriplett commented Oct 30, 2024

rfcbot commented Oct 30, 2024 • edited Loading

traviscross commented Oct 30, 2024

nikomatsakis commented Oct 30, 2024

bors commented Nov 2, 2024

bors commented Nov 5, 2024

bors commented Nov 8, 2024

rfcbot commented Nov 9, 2024

taiki-e commented Nov 9, 2024

Amanieu commented Nov 9, 2024

bors commented Nov 9, 2024

bors commented Nov 10, 2024

taiki-e commented Oct 4, 2024 •

edited

Loading

workingjubilee commented Oct 26, 2024 •

edited

Loading

taiki-e commented Oct 26, 2024 •

edited

Loading

rfcbot commented Oct 30, 2024 •

edited

Loading