Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable f16 tests on x86 Apple platforms #130961

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Enable f16 tests on x86 Apple platforms #130961

merged 1 commit into from
Oct 1, 2024

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Sep 27, 2024 •
edited
Loading

These were disabled because Apple uses a special ABI for f16. compiler-builtins merged a fix for this in 1, which has since propagated to rust-lang/rust. Enable tests since there should be no remaining issues on these platforms.

try-job: x86_64-apple-1
try-job: x86_64-apple-2

@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2024

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 27, 2024
@tgross35
Copy link
Contributor Author

Like #130959, this should have #129385 merge first but we can test now.

@bors try

Cc @beetrees to double check this.

@tgross35 tgross35 added the F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` label Sep 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130961 - tgross35:f16-x86-apple, r=<try>
f78b7e7 
Enable `f16` tests on x86 Apple platforms

These were disabled because Apple uses a special ABI for `f16`. `compiler-builtins` merged a fix for this in [1], which has since propagated to rust-lang/rust. Enable tests since there should be no remaining issues on these platforms.

[1]: rust-lang/compiler-builtins#675

try-job: x86_64-apple-1
try-job: x86_64-apple-2
@bors
Copy link
Contributor

bors commented Sep 27, 2024

⌛ Trying commit 43e4c07 with merge f78b7e7...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Sep 27, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2024
@tgross35
Copy link
Contributor Author

Ah, didn't expect tidy to fail.

@bors try

@bors
Copy link
Contributor

bors commented Sep 27, 2024

⌛ Trying commit a51a1e4 with merge 298573c...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130961 - tgross35:f16-x86-apple, r=<try>
298573c 
Enable `f16` tests on x86 Apple platforms

These were disabled because Apple uses a special ABI for `f16`. `compiler-builtins` merged a fix for this in [1], which has since propagated to rust-lang/rust. Enable tests since there should be no remaining issues on these platforms.

[1]: rust-lang/compiler-builtins#675

try-job: x86_64-apple-1
try-job: x86_64-apple-2
@workingjubilee workingjubilee added the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Sep 28, 2024
@bors
Copy link
Contributor

bors commented Sep 28, 2024

☀️ Try build successful - checks-actions
Build commit: 298573c (298573cca5f98926d43eb36d2bf8edad0f3f1216)

@tgross35
Copy link
Contributor Author

Still blocked until I can rebase on #129385 and drop the second commit, but there isn't anything surprising here.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Sep 28, 2024
@tgross35 tgross35 added the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Sep 28, 2024
@tgross35
Enable f16 tests on x86 Apple platforms
2511cc1 
These were disabled because Apple uses a special ABI for `f16`.
`compiler-builtins` merged a fix for this in [1], which has since
propagated to rust-lang/rust. Enable tests since there should be no
remaining issues on these platforms.

[1]: rust-lang/compiler-builtins#675
@tgross35
Copy link
Contributor Author

tgross35 commented Sep 28, 2024 •
edited
Loading

Rebased after #129385.

@rustbot label -S-blocked

@rustbot rustbot removed the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Sep 28, 2024
@thomcc
Copy link
Member

thomcc commented Sep 30, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Sep 30, 2024

📌 Commit 2511cc1 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2024
@tgross35 tgross35 mentioned this pull request Sep 30, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 30, 2024
@bors
Auto merge of rust-lang#131078 - tgross35:rollup-66to2u9, r=tgross35
c87004a 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#129638 (Hook up std::net to wasi-libc on wasm32-wasip2 target)
 - rust-lang#130877 (rustc_target: Add RISC-V atomic-related features)
 - rust-lang#130914 (Mark some more types as having insignificant dtor)
 - rust-lang#130961 (Enable `f16` tests on x86 Apple platforms)
 - rust-lang#130966 (make ptr metadata functions callable from stable const fn)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 40d0ada into rust-lang:master Oct 1, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 1, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 1, 2024
@rust-timer
Unrolled build for rust-lang#130961
bacf20c 
Rollup merge of rust-lang#130961 - tgross35:f16-x86-apple, r=thomcc

Enable `f16` tests on x86 Apple platforms

These were disabled because Apple uses a special ABI for `f16`. `compiler-builtins` merged a fix for this in [1], which has since propagated to rust-lang/rust. Enable tests since there should be no remaining issues on these platforms.

[1]: rust-lang/compiler-builtins#675

try-job: x86_64-apple-1
try-job: x86_64-apple-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tgross35 @rustbot @bors @rust-log-analyzer @thomcc @workingjubilee