Mark some more types as having insignificant dtor #130914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
insignificant-dtor
branch
from
002ff37
to
3a6df29
Compare
compiler-errors
force-pushed
the
insignificant-dtor
branch
from
3a6df29
to
24290ef
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2024
…er, r=<try> [crater] validate impact of marking more types as `#[rustc_insignificant_dtor]` on tail expr drop order lint Validate impact of rust-lang#130914 on rust-lang#129864 and the tail expr drop order lint. r? `@ghost`
Amanieu
reviewed
Sep 30, 2024
| @@ -237,6 +237,7 @@ macro_rules! acquire { | |||
| /// [rc_examples]: crate::rc#examples | |||
| #[cfg_attr(not(test), rustc_diagnostic_item = "Arc")] | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| #[rustc_insignificant_dtor] | |||
| pub struct Arc< | |||
There was a problem hiding this comment.
It seems that this should also apply to Weak? After all, the only thing that dropping a Weak might do is freeing the Arc and dropping the contained value.
There was a problem hiding this comment.
Yeah. This PR is not meant to be complete; I just marked types that I saw were missing from the fallout of the crater runs I linked above. I'd rather merge this in this state than modify it further.
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 30, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#129638 (Hook up std::net to wasi-libc on wasm32-wasip2 target) - rust-lang#130877 (rustc_target: Add RISC-V atomic-related features) - rust-lang#130914 (Mark some more types as having insignificant dtor) - rust-lang#130961 (Enable `f16` tests on x86 Apple platforms) - rust-lang#130966 (make ptr metadata functions callable from stable const fn) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 1, 2024
Rollup merge of rust-lang#130914 - compiler-errors:insignificant-dtor, r=Amanieu Mark some more types as having insignificant dtor These were caught by rust-lang#129864 (comment), which is implementing a lint for some changes in drop order for temporaries in tail expressions. Specifically, the destructors of `CString` and the bitpacked repr for `std::io::Error` are insignificant insofar as they don't have side-effects on things like locking or synchronization; they just free memory. See some discussion on rust-lang#89144 for what makes a drop impl "significant"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were caught by #129864 (comment), which is implementing a lint for some changes in drop order for temporaries in tail expressions.
Specifically, the destructors of
CStringand the bitpacked repr forstd::io::Errorare insignificant insofar as they don't have side-effects on things like locking or synchronization; they just free memory.See some discussion on #89144 for what makes a drop impl "significant"