syntax: make match arms store the expr directly. #12669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `ast::Arm` was always storing a single `ast::Expr` wrapped in an `ast::Block` (for historical reasons, AIUI), so we might as just store that expr directly. Closes rust-lang#3085.
| @@ -915,4 +915,3 @@ fn bit_str(bit: uint) -> ~str { | |||
| let lobits = 1 << (bit & 0xFF); | |||
| format!("[{}:{}-{:02x}]", bit, byte, lobits) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Does your editor automatically remove newlines at the end of files? Do we have a policy about it?
There was a problem hiding this comment.
It seems to remove useless whitespace (e.g. trailing whitespace on lines and entire files).
(Note that this doesn't remove the very last \n, just s/\n+$/\n/ if you'll excuse the regex.)
|
Travis doesn't like this change but I do ;) Looking good so far. 🍰 |
|
The travis failure is spurious (at least, every recent PR is failing with that error). |
bors
added a commit
that referenced
this pull request
Mar 4, 2014
syntax: make match arms store the expr directly. Previously `ast::Arm` was always storing a single `ast::Expr` wrapped in an `ast::Block` (for historical reasons, AIUI), so we might as just store that expr directly. Closes #3085.
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syntax: make match arms store the expr directly.
Previously
ast::Armwas always storing a singleast::Exprwrapped in anast::Block(for historical reasons, AIUI), so we might as just storethat expr directly.
Closes #3085.