Expand nested items within a backtrace. #12671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| |item| items.push(item)); | ||
| decorator_items.push_all(items.move_iter() | ||
| .flat_map(|item| expand_item(item, fld).move_iter()) | ||
| .collect()); |
There was a problem hiding this comment.
Could we avoid collect() here? I don't know if there's a vec method that takes an Iterator<T>, but if not, there probably should be.
|
r=me with |
|
(Oh, it seems |
|
It will be implemented when #12673 lands. |
|
We're using SmallVec anyway, so I will implement extend for that. Yeah, this was a total pain to track down. Sadly I couldn't think of a nice way to test it either. |
Fixes a regression from rust-lang#4913 which causes items to be exanded with spans lacking expn_info from the context's current backtrace.
|
@huon - ready for re-review - implemented using SmallVector::extend |
bors
added a commit
that referenced
this pull request
Mar 5, 2014
Fixes a regression from #4913 which causes items to be exanded with spans lacking expn_info from the context's current backtrace.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression from #4913 which causes items to be exanded with spans lacking expn_info from the context's current backtrace.