Make .swap_remove return Option<T> #12481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one of the last raw "indexing" method on vectors that returns `T` instead of the Option.
`.reserve_exact` can cause pathological O(n^2) behaviour, so providing a `.reserve` that ensures that capacity doubles (if you step 1, 2, ..., n) is more efficient. cc rust-lang#11949
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
assist: add label to loop closes: rust-lang#12392 I changed `'loop` to `'l`, as `cargo check` says `'loop` is an invalid label name.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 4, 2024
RFC: Document Clippy's teams and team duties First the big announcement: **We want to add a new subteam for regular contributors to give them triage rights.** --- This PR adds a new section to the book which describes the Clippy and Clippy-Contributor teams, with their duties and membership requirements. This is just an initial draft, that outlines what, I think, their responsibilities should be. I hope everyone in the team is okay with me posting this directly to GitHub. I think a PR makes collaboration a bit easier. [:framed_picture: Rendered :framed_picture:](https://github.com/xFrednet/rust-clippy/blob/add-team-docs/book/src/development/the_team.md) --- Once we've decided on this document, I'll create a PR to add the new team on GitHub. As part of this, we'll also reach out to some active contributors, to ask if they would like to join the new team. --- cc: `@rust-lang/clippy` cc: rust-lang#6627 changelog: none r? `@flip1995`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means it now matches (almost) everything else that does indexing into vectors.
Also, minor addition of
.reservetovec_ng.