Rolling up PRs in the queue #12535
Closed
Rolling up PRs in the queue #12535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a layman's version of realpath() for metadata::loader to use in order to not error on symlinks pointing to the same file. Closes rust-lang#12459
On windows lines are delimited with \r\n while on unix they're delimited with \n. cc rust-lang#12471
* compile-fail/vec-add.rs is obsolete, there are no mutable vectors any more, rust-lang#2711 is closed * compile-fail/issue-1451.rs is obsolete, there are no more structural records, rust-lang#1451 is closed * compile-fail/issue-2074.rs is obsolete, an up to date test is in run-pass/nested-enum-same-names.rs, rust-lang#2074 is closed * compile-fail/omitted-arg-wrong-types.rs is obsolete, rust-lang#2093 is closed
This is one of the last raw "indexing" method on vectors that returns `T` instead of the Option.
`.reserve_exact` can cause pathological O(n^2) behaviour, so providing a `.reserve` that ensures that capacity doubles (if you step 1, 2, ..., n) is more efficient. cc rust-lang#11949
file. Previously multibyte UTF-8 chars were being recorded as byte offsets from the start of the file, and then later compared against global byte positions, resulting in the compiler possibly thinking it had a byte position pointing inside a multibyte character, if there were multibyte characters in any non-crate files. (Although, sometimes the byte offsets line up just right to not ICE, but that was a coincidence.) Fixes rust-lang#11136. Fixes rust-lang#11178.
They are still are not completely correct, since it does not handle graphemes at all, just codepoints, but at least it handles the common case correctly. The calculation was previously very wrong (rather than just a little bit wrong): it wasn't accounting for the fact that every character is 1 byte, and so multibyte characters were pretending to be zero width. cc rust-lang#8706
The by-value argument is a copy that is only valid for the duration of the function call, therefore keeping any pointer to it that outlives the call is illegal.
This makes using control-flow-y macros like `spawn! { ... }` more fluent
and natural.
cc rust-lang#11892.
In its first pass, namely gather_loans, the borrow checker tracks the initialization sites among other things it does. It does so for let bindings with initializers but not for bindings in match arms, which are effectively also assignments. This patch does that for borrow checker. Closes rust-lang#12452.
It appears that travis doesn't stop running script commands after the first one fails (see travis-ci/travis-ci#1066), so chain all our commands together with && for now.
with the new modules that moved from extra, and with other undocumented folders. also add a note about potential changes.
We should be using the package std::num::sqrt instead of the sqrt function that was defined to return 0.0
bors
added a commit
that referenced
this pull request
Feb 25, 2014
Closes #12474 (rustc: Don't error on the rlib symlinks) r=brson Closes #12475 (Use lines_any() when parsing output form "ar") r=brson Closes #12476 (Remove some obsolete ignored tests) r=alexcrichton Closes #12481 (Make .swap_remove return Option<T>) r=brson Closes #12485 (Remove some non-essential trait re-exports from the prelude.) r=brson Closes #12489 (Handle multibyte characters in source files better) r=alexcrichton Closes #12494 (Mark by-value parameters that are passed on the stack as nocapture) r=nmatsakis Closes #12497 (syntax: allow stmt/expr macro invocations to be delimited by {}) r=alexcrichton Closes #12508 (Match binding is assignment) r=nmatsakis Closes #12513 (Run the travis build as one large command) r=huonw Closes #12515 (Update source code layout in src/) r=alexcrichton Closes #12521 (Tutorial: Add std::num::sqrt to the example) r=cmr Closes #12529 (test: single-variant enum can't be dereferenced) r=huonw
|
Thanks for taking care of our pull requests :) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…ykril Automatically instaciate trivially instaciable structs in "Generate new" and "Fill struct fields" As proposed in rust-lang#12535 this PR changes the "Generate new" and "Fill struct fields" assist/diagnostic to instanciate structs with no fields and enums with a single empty variant. For example: ```rust pub enum Bar { Bar {}, } struct Foo<T> { a: usize, bar: Bar, _phantom: std::marker::PhantomData<T>, } impl<T> Foo<T> { /* generate new */ fn random() -> Self { Self { /* Fill struct fields */ } } } ``` was previously: ```rust impl<T> Foo<T> { fn new(a: usize, bar: Bar, _phantom: std::marker::PhantomData<T>) -> Self { Self { a, bar, _phantom } } fn random() -> Self { Self { a: todo!(), bar: todo!(), _phantom: todo!(), } } } ``` and is now: ```rust impl<T> Foo<T> { fn new(a: usize) -> Self { Self { a, bar: Bar::Bar {}, _phantom: std::marker::PhantomData } } fn random() -> Self { Self { a: todo!(), bar: Bar::Bar {}, _phantom: std::marker::PhantomData, } } } ``` I'd be happy about any suggestions. ## TODO - [x] deduplicate `use_trivial_constructor` (unclear how to do as it's used in two separate crates) - [x] write tests Closes rust-lang#12535
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 4, 2024
`useless_asref`: do not lint `.as_ref().map(Arc::clone)` This applies to `Arc`, `Rc`, and their weak variants. Using `.clone()` would be less idiomatic. This follows the discussion in <rust-lang/rust-clippy#12528 (comment)>. changelog: [`useless_asref`]: do not lint `.as_ref().map(Arc::clone)` and similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12474 (rustc: Don't error on the rlib symlinks) r=brson
Closes #12475 (Use lines_any() when parsing output form "ar") r=brson
Closes #12476 (Remove some obsolete ignored tests) r=alexcrichton
Closes #12481 (Make .swap_remove return Option) r=brson
Closes #12485 (Remove some non-essential trait re-exports from the prelude.) r=brson
Closes #12489 (Handle multibyte characters in source files better) r=alexcrichton
Closes #12494 (Mark by-value parameters that are passed on the stack as nocapture) r=nmatsakis
Closes #12497 (syntax: allow stmt/expr macro invocations to be delimited by {}) r=alexcrichton
Closes #12508 (Match binding is assignment) r=nmatsakis
Closes #12513 (Run the travis build as one large command) r=huonw
Closes #12515 (Update source code layout in src/) r=alexcrichton
Closes #12521 (Tutorial: Add std::num::sqrt to the example) r=cmr
Closes #12529 (test: single-variant enum can't be dereferenced) r=huonw