Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span debugger #12087

Merged
merged 3 commits into from
Feb 7, 2014
Merged

Span debugger #12087

merged 3 commits into from
Feb 7, 2014

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Feb 7, 2014

No description provided.

@sanxiyn
Copy link
Member Author

sanxiyn commented Feb 7, 2014

Before:

span.rs:2     let _ = || ();
                    ^~~~~~~
span.rs:3     [0].len();
              ^~~~~~~~~~
span.rs:4     (0);
              ^~~~

After:

span.rs:2     let _ = || ();
                      ^~~~~
span.rs:3     [0].len();
              ^~~~~~~~~
span.rs:4     (0);
              ^~~

huonw
huonw reviewed Feb 7, 2014
View reviewed changes
src/librustc/front/show_span.rs
// option. This file may not be copied, modified, or distributed
// except according to those terms.

use syntax::ast;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a comment about what this is doing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(What the file is doing, that is; I know what the import is doing. :P )

@sanxiyn
Copy link
Member Author

sanxiyn commented Feb 7, 2014

Added some comments.

bors added a commit that referenced this pull request Feb 7, 2014
@bors
auto merge of #12087 : sanxiyn/rust/show-span, r=huonw
c3ccaac
@bors bors closed this Feb 7, 2014
@bors bors merged commit e5463b9 into rust-lang:master Feb 7, 2014
@sanxiyn sanxiyn deleted the show-span branch February 9, 2014 05:58
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 8, 2024
@bors
Auto merge of rust-lang#12087 - marcin-serwin:ref_as_ptr_cast, r=blyxyas
34e4c9f 
Add new lint: `ref_as_ptr`

Fixes rust-lang#10130

Added new lint `ref_as_ptr` that checks for conversions from references to pointers and suggests using `std::ptr::from_{ref, mut}` instead.

The name is different than suggested in the issue (`as_ptr_cast`) since there were some other lints with similar names (`ptr_as_ptr`, `borrow_as_ptr`) and I wanted to follow the convention.

Note that this lint conflicts with the `borrow_as_ptr` lint in the sense that it recommends changing `&foo as *const _` to `std::ptr::from_ref(&foo)` instead of `std::ptr::addr_of!(foo)`. Personally, I think the former is more readable and, in contrast to `addr_of` macro, can be also applied to temporaries (cf. rust-lang#9884).

---

changelog: New lint: [`ref_as_ptr`]
[rust-lang#12087](rust-lang/rust-clippy#12087)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanxiyn @huonw @bors