Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra::flatpipes #9884

Closed
brson opened this issue Oct 16, 2013 · 0 comments · Fixed by #9886
Closed

Remove extra::flatpipes #9884

brson opened this issue Oct 16, 2013 · 0 comments · Fixed by #9886
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Oct 16, 2013

Most of the tests have been disabled so flatpipes is pretty busted. This can be reimplemented on top of the new I/O system later.

bors added a commit that referenced this issue Oct 16, 2013
@bors bors closed this as completed in 1943024 Oct 16, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 30, 2023
[`borrow_as_ptr`]: Ignore temporaries

Fixes rust-lang#9884

changelog: [`borrow_as_ptr`]: Ignore temporaries
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 8, 2024
Add new lint: `ref_as_ptr`

Fixes rust-lang#10130

Added new lint `ref_as_ptr` that checks for conversions from references to pointers and suggests using `std::ptr::from_{ref, mut}` instead.

The name is different than suggested in the issue (`as_ptr_cast`) since there were some other lints with similar names (`ptr_as_ptr`, `borrow_as_ptr`) and I wanted to follow the convention.

Note that this lint conflicts with the `borrow_as_ptr` lint in the sense that it recommends changing `&foo as *const _` to `std::ptr::from_ref(&foo)` instead of `std::ptr::addr_of!(foo)`. Personally, I think the former is more readable and, in contrast to `addr_of` macro, can be also applied to temporaries (cf. rust-lang#9884).

---

changelog: New lint: [`ref_as_ptr`]
[rust-lang#12087](rust-lang/rust-clippy#12087)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant