Remove unnecessary impl sorting in queries and metadata

[compiler-errors]

Removes unnecessary impl sorting because queries already return their keys in HIR definition order: #120371 (comment)

r? @cjgillot or @lcnr -- unless I totally misunderstood what was being asked for here? 😆

fixes #120371

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[cjgillot]

I need to check something before approving. I'll get back to you some time next week.

[compiler-errors]

will fix later

[bors]

☔ The latest upstream changes (presumably #121489) made this pull request unmergeable. Please resolve the merge conflicts.

[compiler-errors]

@cjgillot: Did you have an opportunity to investigate this?

[bors]

☔ The latest upstream changes (presumably #124558) made this pull request unmergeable. Please resolve the merge conflicts.

[wesleywiser]

Hi @cjgillot, just wanted to see if you had any more feedback for @compiler-errors 🙂

[wesleywiser]

r? rust-lang/compiler

[compiler-errors]

TaKO8Ki hasn't reviewed code for a month, and also I don't believe they're familiar with metadata encoding. I'm going to preemptively re-roll.

r? compiler

[lcnr]

r=me after rebase. We discussed this on zulip previously where i looked into the code. I am fairly confident that they are already sorted and this can always be reverted/solved differently going forward

[compiler-errors]

@bors r=lcnr rollup=never

[bors]

📌 Commit e0ba193 has been approved by lcnr

It is now in the queue for this repository.

[bors]

⌛ Testing commit e0ba193 with merge 2a5e296...

[Mark-Simulacrum]

@bors retry -- yielding to stable release

[bors]

⌛ Testing commit e0ba193 with merge 0f8534e...

[bors]

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 0f8534e to master...

[rust-timer]

Finished benchmarking commit (0f8534e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.2%	[-2.1%, -0.4%]	2
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.3%]	2
All ❌✅ (primary)	-1.2%	[-2.1%, -0.4%]	2

Max RSS (memory usage)

Results (secondary 4.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.8%	[4.2%, 5.8%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -1.4%, secondary -3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.8%	[3.8%, 3.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.9%	[-3.6%, -1.1%]	12
Improvements ✅ (secondary)	-3.2%	[-3.7%, -2.5%]	13
All ❌✅ (primary)	-1.4%	[-3.6%, 3.8%]	13

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.021s -> 771.951s (-0.01%)
Artifact size: 328.86 MiB -> 328.89 MiB (0.01%)