-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uplift most type-system related error reporting from rustc_infer
to rustc_trait_selection
#128041
Uplift most type-system related error reporting from rustc_infer
to rustc_trait_selection
#128041
Conversation
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred in engine.rs, potentially modifying the public API of Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustc_infer
to rustc_trait_selection
This comment has been minimized.
This comment has been minimized.
7973d51
to
bad64f1
Compare
This comment has been minimized.
This comment has been minimized.
bad64f1
to
93ef03a
Compare
☔ The latest upstream changes (presumably #120812) made this pull request unmergeable. Please resolve the merge conflicts. |
93ef03a
to
e9e9495
Compare
@bors r+ rollup=never p=1 |
…rait-sel, r=lcnr Uplift most type-system related error reporting from `rustc_infer` to `rustc_trait_selection` Completes the major part of rust-lang#127492. The only cleanup that's needed afterwards is to actually use normalization in favor of the callback where needed, and deleting `can_eq_shallow`. r? lcnr Sorry for the large diff! Would prefer if comments can be handled in a follow-up (unless they're absolutely dealbreakers) because it seems bitrotty to let this sit.
💔 Test failed - checks-actions |
Due to that rwlock unsoundness it seems @bors retry |
(there's some race condition unsoundness in rwlock that has been fucking up CI) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (20f23ab): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 771.169s -> 770.41s (-0.10%) |
Completes the major part of #127492. The only cleanup that's needed afterwards is to actually use normalization in favor of the callback where needed, and deleting
can_eq_shallow
.r? lcnr
Sorry for the large diff! Would prefer if comments can be handled in a follow-up (unless they're absolutely dealbreakers) because it seems bitrotty to let this sit.