Mention the syntax for `use` on `mod foo;` if `foo` doesn't exist #116992

estebank · 2023-10-20T20:03:54Z

Newcomers might get confused that mod is the only way of defining scopes, and that it can be used as if it were use.

Fix #69492.

rustbot · 2023-10-20T20:04:02Z

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

tests/ui/error-codes/E0583.stderr

oli-obk · 2023-10-20T22:58:48Z

@bors r+ rollup

bors · 2023-10-20T22:58:50Z

📌 Commit 8950d80 has been approved by oli-obk

It is now in the queue for this repository.

Mention the syntax for `use` on `mod foo;` if `foo` doesn't exist Newcomers might get confused that `mod` is the only way of defining scopes, and that it can be used as if it were `use`. Fix rust-lang#69492.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#116911 (Suggest relaxing implicit `type Assoc: Sized;` bound) - rust-lang#116961 (Typo suggestion to change bindings with leading underscore) - rust-lang#116964 (Add stable Instance::body() and RustcInternal trait) - rust-lang#116992 (Mention the syntax for `use` on `mod foo;` if `foo` doesn't exist) - rust-lang#116995 (Point at assoc fn definition on type param divergence) Failed merges: - rust-lang#116974 (coverage: Fix inconsistent handling of function signature spans) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2023-10-21T08:07:46Z

@bors r-
may need more blessings on windows? #117002 (comment)

Newcomers might get confused that `mod` is the only way of defining scopes, and that it can be used as if it were `use`. Fix rust-lang#69492.

estebank · 2023-10-21T15:56:23Z

@bors r=oli-obk

bors · 2023-10-21T15:56:24Z

📌 Commit 2cca435 has been approved by oli-obk

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#116312 (Initiate the inner usage of `cfg_match` (Compiler)) - rust-lang#116928 (fix bootstrap paths in triagebot.toml) - rust-lang#116955 (Updated README with expandable table of content.) - rust-lang#116981 (update the registers of csky target) - rust-lang#116992 (Mention the syntax for `use` on `mod foo;` if `foo` doesn't exist) - rust-lang#117026 (Fix broken link to Ayu theme in the rustdoc book) - rust-lang#117028 (Remove unnecessary `all` in Box) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116992 - estebank:issue-69492, r=oli-obk Mention the syntax for `use` on `mod foo;` if `foo` doesn't exist Newcomers might get confused that `mod` is the only way of defining scopes, and that it can be used as if it were `use`. Fix rust-lang#69492.

rustbot assigned oli-obk Oct 20, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 20, 2023

estebank mentioned this pull request Oct 20, 2023

E0583: Improve error message to help with use vs mod confusion #69492

Closed

Noratrieb reviewed Oct 20, 2023

View reviewed changes

tests/ui/error-codes/E0583.stderr Outdated Show resolved Hide resolved

estebank force-pushed the issue-69492 branch from e248813 to 41006e0 Compare October 20, 2023 20:25

This comment has been minimized.

Sign in to view

estebank force-pushed the issue-69492 branch from 41006e0 to 8950d80 Compare October 20, 2023 22:31

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2023

matthiaskrgr mentioned this pull request Oct 20, 2023

Rollup of 5 pull requests #117002

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 21, 2023

Mention the syntax for use on mod foo; if foo doesn't exist

2cca435

Newcomers might get confused that `mod` is the only way of defining scopes, and that it can be used as if it were `use`. Fix rust-lang#69492.

estebank force-pushed the issue-69492 branch from 8950d80 to 2cca435 Compare October 21, 2023 15:56

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 21, 2023

matthiaskrgr mentioned this pull request Oct 21, 2023

Rollup of 7 pull requests #117030

Merged

bors merged commit 31865b7 into rust-lang:master Oct 21, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 21, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

estebank deleted the issue-69492 branch November 9, 2023 05:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mention the syntax for `use` on `mod foo;` if `foo` doesn't exist #116992

Mention the syntax for `use` on `mod foo;` if `foo` doesn't exist #116992

estebank commented Oct 20, 2023

rustbot commented Oct 20, 2023

This comment has been minimized.

oli-obk commented Oct 20, 2023

bors commented Oct 20, 2023

matthiaskrgr commented Oct 21, 2023

estebank commented Oct 21, 2023

bors commented Oct 21, 2023

Mention the syntax for use on mod foo; if foo doesn't exist #116992

Mention the syntax for use on mod foo; if foo doesn't exist #116992

Conversation

estebank commented Oct 20, 2023

rustbot commented Oct 20, 2023

This comment has been minimized.

oli-obk commented Oct 20, 2023

bors commented Oct 20, 2023

matthiaskrgr commented Oct 21, 2023

estebank commented Oct 21, 2023

bors commented Oct 21, 2023

Mention the syntax for `use` on `mod foo;` if `foo` doesn't exist #116992

Mention the syntax for `use` on `mod foo;` if `foo` doesn't exist #116992