rand use getrandom for freebsd (available since 12.x)

[devnexen]

No description provided.

[rustbot]

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[Mark-Simulacrum]

It seems like this should wait for #89058 to go through?

[devnexen]

indeed .. expecting all goes to plan🙂

[Mark-Simulacrum]

Okay, I'll mark as blocked for now. In general I'm not sure keeping this open ~indefinitely is helpful, at minimum please signal that it is in fact blocked when opening such PRs.

[bors]

☔ The latest upstream changes (presumably #114103) made this pull request unmergeable. Please resolve the merge conflicts.

[workingjubilee]

That FCP completed and was accepted, buuut PR now needs rebase.

@rustbot author

[workingjubilee]

ope!
looks good!
@bors r+

[bors]

📌 Commit 4b73cf3 has been approved by workingjubilee

It is now in the queue for this repository.

[bors]

⌛ Testing commit 4b73cf3 with merge 7d048ec...

[rust-log-analyzer]

The job i686-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests\ui\runtime\backtrace-debuginfo.rs stdout ----

error: test run failed!
status: exit code: 101
command: PATH="C:\a\rust\rust\build\i686-pc-windows-gnu\stage2\lib\rustlib\i686-pc-windows-gnu\lib;C:\a\rust\rust\build\i686-pc-windows-gnu\stage0-bootstrap-tools\i686-pc-windows-gnu\release\deps;C:\a\rust\rust\build\i686-pc-windows-gnu\stage0\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\mingw32\bin;C:\hostedtoolcache\windows\Python\3.11.5\x64\Scripts;C:\hostedtoolcache\windows\Python\3.11.5\x64;C:\msys64\usr\bin;C:\a\rust\rust\sccache;C:\PROGRA~1\MongoDB\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\2.11.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\Program Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-4.3.1\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.20.8\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.382-5\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\ProgramData\Chocolatey\bin;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\test\\ui\\runtime\\backtrace-debuginfo\\a.exe"
---------------------------------------
trace does not match position list
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184", "backtrace-debuginfo.rs:121"]
--- stdout
backtrace-debuginfo.rs:121
backtrace-debuginfo.rs:184

---
                       at /rustc/FAKE_PREFIX\library\std\src/panicking.rs:638:12
   9:   0xd40fd0 - <unknown>
  10:   0xa9794a - backtrace_debuginfo::main::h7f1d9bc6ac819adb
                       at C:\a\rust\rust\tests\ui\runtime\backtrace-debuginfo.rs:184:9
  11:   0xa842f9 - core::ops::function::FnOnce::call_once::hf285219168451d93
                       at /rustc/FAKE_PREFIX\library\core\src\ops/function.rs:250:5
  12:   0xa831d1 - std::sys_common::backtrace::__rust_begin_short_backtrace::hf088feb6ac2a8400
                       at /rustc/FAKE_PREFIX\library\std\src\sys_common/backtrace.rs:154:18
  13:   0xa83243 - std::rt::lang_start::{{closure}}::h55cced40e8edb133
                       at /rustc/FAKE_PREFIX\library\std\src/rt.rs:166:18
  14: 0x71618a0a - std::rt::lang_start_internal::ha57caf445342769f
  15:   0xa8321b - std::rt::lang_start::hd453c07e1bc8dce0
                       at /rustc/FAKE_PREFIX\library\std\src/rt.rs:165:17
  16:   0xa979ce - _main
  17:   0xa81386 - ___tmainCRTStartup
  19: 0x7775777d - <unknown>
  20: 0x7775774d - <unknown>
------------------------------------------
--- stderr -------------------------------

[bors]

💔 Test failed - checks-actions

[ehuss]

@bors r-

queue synchronize

[ehuss]

@bors r=workingjubilee

Re-adding to the queue, the previous error was due to a flaky test (#117097).

[bors]

📌 Commit 4b73cf3 has been approved by workingjubilee

It is now in the queue for this repository.

[workingjubilee]

Thanks for finding the flaky test!

[tgross35]

Shouldn't this still be blocked on #89058?