Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #104080

Closed
wants to merge 24 commits into from
Closed

Commits on Nov 4, 2022

  1. rustdoc: render late-bound lifetimes in generic parameter list of cro…

    …ss-crate functions and methods
    fmease committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    5965af7 View commit details
    Browse the repository at this point in the history
  2. rustdoc: render unnamed arguments as underscores in cross-crate funct…

    …ions & function pointers
    
    for consistency with the way we display local definitions (cleaned from HIR, not from rustc_middle).
    fmease committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    9cdab67 View commit details
    Browse the repository at this point in the history
  3. rustdoc: move cross-crate lifetime/outlives bounds on GAT params from…

    … where-clause to param declaration site
    
    I've overlooked this in rust-lang#103190.
    fmease committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    2d9755f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1ac7034 View commit details
    Browse the repository at this point in the history
  5. rustdoc: render the return type of cross-crate Fn-family trait boun…

    …ds in trait-object types
    fmease committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    71561f8 View commit details
    Browse the repository at this point in the history
  6. rustdoc: add test for cross-crate trait-object types

    as well as some FIXMEs
    fmease committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    7ec50b6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5ccaed2 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2022

  1. Add type_array to BaseTypeMethods

    Moved type_array function to rustc_codegen_ssa::BaseTypeMethods trait.
    This allows using normal alloca function to create arrays as suggested in
    rust-lang#104022.
    
    Signed-off-by: Ayush Singh <[email protected]>
    Ayush1325 committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    299bc61 View commit details
    Browse the repository at this point in the history
  2. fix: typo

    Rejyr committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    e15c406 View commit details
    Browse the repository at this point in the history
  3. rustdoc: remove unused CSS #sidebar-filler

    This hack was removed in 6a5f8b1, but the
    CSS was left in.
    notriddle committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    b34fdd3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    24d86a1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f414715 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0e23d90 View commit details
    Browse the repository at this point in the history
  7. Make underscore_literal_suffix a hard error.

    It's been a warning for 5.5 years. Time to make it a hard error.
    
    Closes rust-lang#42326.
    nnethercote committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    dba6fc3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f28875e View commit details
    Browse the repository at this point in the history
  9. Print "Checking/Building ..." message even when --dry-run is passed

    This makes it a lot easier to understand what commands will be run without
    having to parse the `-vv` output, which isn't meant to be user facing.
    jyn514 committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    fd1a393 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#103885 - fmease:rustdoc-various-cross-crate…

    …-reexport-fixes, r=cjgillot,GuillaumeGomez
    
    rustdoc: various cross-crate reexport fixes
    
    Fixes for various smaller cross-crate reexport issues.
    The PR is split into several commits for easier review. Will be squashed after approval.
    
    Most notable changes:
    
    * We finally render late-bound lifetimes in the generic parameter list of cross-crate functions & methods.
      Previously, we would display the re-export of `pub fn f<'s>(x: &'s str) {}` as `pub fn f(x: &'s str)`
    * We now render unnamed parameters of cross-crate functions and function pointers as underscores
      since that's exactly what we do for local definitions, too. Mentioned as a bug in rust-lang#44306.
    * From now on, the rendering of cross-crate trait-object types is more correct:
      * `for<>` parameter lists (for higher-ranked lifetimes) are now shown
      * the return type of `Fn{,Mut,Once}` trait bounds is now displayed
    
    Regarding the last list item, here is a diff for visualization (before vs. after):
    
    ```patch
    - dyn FnOnce(&'any str) + 'static
    + dyn for<'any> FnOnce(&'any str) -> bool + 'static
    ```
    
    The redundant `+ 'static` will be removed in a follow-up PR that will hide trait-object lifetime-bounds if they coincide with [their default](https://doc.rust-lang.org/reference/lifetime-elision.html#default-trait-object-lifetimes) (see [Zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/clean_middle_ty.3A.20I.20need.20to.20add.20a.20parameter/near/307143097)). `FIXME(fmease)`s were added.
    
    `@rustbot` label A-cross-crate-reexports
    r? `@GuillaumeGomez`
    Yuki Okushi authored Nov 6, 2022
    Configuration menu
    Copy the full SHA
    5fadbd0 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#103914 - nnethercote:close-42326, r=petroch…

    …enkov
    
    Make underscore_literal_suffix a hard error.
    
    It's been a warning for 5.5 years. Time to make it a hard error.
    
    Closes rust-lang#42326.
    
    r? `@pnkfelix`
    Yuki Okushi authored Nov 6, 2022
    Configuration menu
    Copy the full SHA
    ceff97a View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#104045 - Ayush1325:type_array, r=nikic

    Add type_array to BaseTypeMethods
    
    Moved `type_array` function to `rustc_codegen_ssa::BaseTypeMethods` trait. This allows using normal `alloca` function to create arrays as suggested in rust-lang#104022.
    
    Signed-off-by: Ayush Singh <[email protected]>
    Yuki Okushi authored Nov 6, 2022
    Configuration menu
    Copy the full SHA
    874e795 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#104059 - Rejyr:rustc_middle-lint-typo, r=pe…

    …trochenkov
    
    Fix typo in `rustc_middle/lint.rs`
    Yuki Okushi authored Nov 6, 2022
    Configuration menu
    Copy the full SHA
    77d938c View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#104062 - notriddle:notriddle/sidebar-filler…

    …, r=GuillaumeGomez
    
    rustdoc: remove unused CSS `#sidebar-filler`
    
    This hack was removed in 6a5f8b1, but the CSS was left in.
    Yuki Okushi authored Nov 6, 2022
    Configuration menu
    Copy the full SHA
    4d5860c View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#104065 - GuillaumeGomez:css-migrate-logo-fi…

    …lter, r=notriddle
    
    Migrate rust logo filter to CSS variables
    Yuki Okushi authored Nov 6, 2022
    Configuration menu
    Copy the full SHA
    94334d3 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#104066 - TimNN:riscv-layout, r=nikic

    LLVM 16: Update RISCV data layout
    
    The RISCV data layout was changed in llvm/llvm-project@974e2e6.
    
    This updates all `riscv64*` targets, though I don't really know what the difference between the `gc` and `imac` ones is.
    
    Passes `x test codegen` at LLVM head and with the currently bundled LLVM version. Without this patch, some tests fail with:
    
    > error: internal compiler error: compiler/rustc_codegen_llvm/src/context.rs:192:13: data-layout for target `riscv64gc-unknown-none-elf`, `e-m:e-p:64:64-i64:64-i128:128-n64-S128`, differs from LLVM target's `riscv64` default layout, `e-m:e-p:64:64-i64:64-i128:128-n32:64-S128
    Yuki Okushi authored Nov 6, 2022
    Configuration menu
    Copy the full SHA
    6b59653 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#104078 - jyn514:dry-run-progress, r=Mark-Si…

    …mulacrum
    
    Print "Checking/Building ..." message even when --dry-run is passed
    
    Print "Checking/Building ..." message even when --dry-run is passed
    
    This makes it a lot easier to understand what commands will be run without
    having to parse the `-vv` output, which isn't meant to be user facing.
    
    I also want to change these messages at some point (rust-lang#102003) and this change will make it easier to paste a before/after comparison without having to actually build a stage 2 compiler.
    Yuki Okushi authored Nov 6, 2022
    Configuration menu
    Copy the full SHA
    e35059d View commit details
    Browse the repository at this point in the history