Re-add rustc_codegen_ssa::builder::array_alloca

[Ayush1325]

This function was removed in the #102551
I need this function in #100316 for the custom entry function for UEFI.

Signed-off-by: Ayush Singh [email protected]

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wesleywiser (or someone else) soon.

Please see the contribution instructions for more information.

[rustbot]

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

[nikic]

From a brief glance to #100316, this looks unnecessary. Array allocas are non-canonical and only needed if the alloca is dynamically sized, which does not appear to be the case here. You can create a standard [2 x ptr] alloca.

[Ayush1325]

From a brief glance to #100316, this looks unnecessary. Array allocas are non-canonical and only needed if the alloca is dynamically sized, which does not appear to be the case here. You can create a standard [2 x ptr] alloca.

Thanks. When you mean standard [2 x ptr] alloca, do you mean something like this:

bx.alloca(cx.type_array(cx.type_i8p(), bx.const_int(cx.type_int(), 2)), Align::ONE);

[nikic]

It's probably just cx.type_array(cx.type_i8p(), 2), and that alignment looks somewhat dubious, but the general idea is right.