Add suggestion to the "missing native library" error #103000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-translation
|
r? @eholk (rust-highfive has picked a reviewer for you, use r? to override) |
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
rust-highfive
added
the
S-waiting-on-review
| @@ -0,0 +1,6 @@ | |||
| error: could not find native static library `libfoo.a`, perhaps an -L flag is missing? | |||
| | | |||
| = help: only provide the library name `foo`, not the full filename | |||
There was a problem hiding this comment.
It's a shame we don't have span information here to point out the link attr or ideally the "libfoo.a".
Rageking8
reviewed
Oct 13, 2022
| @@ -164,6 +164,7 @@ metadata_failed_write_error = | |||
|
|
|||
| metadata_missing_native_library = | |||
| could not find native static library `{$libname}`, perhaps an -L flag is missing? | |||
| .help = only provide the library name `{$suggestedname}`, not the full filename | |||
There was a problem hiding this comment.
Suggested change
| .help = only provide the library name `{$suggestedname}`, not the full filename | |
| .help = only provide the library name `{$suggestedname}`, without the extension |
Is this better or worse?
There was a problem hiding this comment.
I like that it's more explicit about what is wrong, but unix platforms also have a "lib" prefix applied to the filename that the user also needs to remove and saying "without the prefix and extension" seems pretty wordy to me.
If we fail to locate a native library that we are linking with, it could be the case the user entered a complete file name like `foo.lib` or `libfoo.a` when we expect them to simply provide `foo`. In this situation, we now detect that case and suggest the user only provide the library name itself.
wesleywiser
force-pushed
the
suggest_libname
branch
from
3ce9c1c
to
097b6d3
Compare
|
Wonderful, thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 13, 2022
…piler-errors Add suggestion to the "missing native library" error If we fail to locate a native library that we are linking with, it could be the case the user entered a complete file name like `foo.lib` or `libfoo.a` when we expect them to simply provide `foo`. In this situation, we now detect that case and suggest the user only provide the library name itself.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 14, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103000 (Add suggestion to the "missing native library" error) - rust-lang#103006 (rustdoc: don't ICE on `TyKind::Typeof`) - rust-lang#103008 (replace ReErased with fresh region vars in opaque types) - rust-lang#103011 (Improve rustdoc `unsafe-fn` GUI test) - rust-lang#103013 (Add new bootstrap entrypoints to triagebot) - rust-lang#103016 (Ensure enum cast moves) - rust-lang#103021 (Add links to relevant pages to find constraint information) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we fail to locate a native library that we are linking with, it could be the case the user entered a complete file name like
foo.liborlibfoo.awhen we expect them to simply providefoo.In this situation, we now detect that case and suggest the user only provide the library name itself.