replace ReErased with fresh region vars in opaque types #103008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? oli-obk |
|
lol rustbot r? @oli-obk |
jackh726
approved these changes
Oct 13, 2022
| @@ -748,14 +746,25 @@ fn check_opaque_meets_bounds<'tcx>( | |||
| let ocx = ObligationCtxt::new(&infcx); | |||
| let opaque_ty = tcx.mk_opaque(def_id.to_def_id(), substs); | |||
|
|
|||
| // `ReErased` regions appear in the "parent_substs" of the closures and generators. | |||
| // We're ignoring them here and replacing them with fresh region variables. | |||
| // FIXME: I think this is correct but it needs a thorough argument. -aliemjay | |||
|
Thanks! r=me with the FIXME removed |
aliemjay
force-pushed
the
opaque-parent-substs
branch
from
9e99fa7
to
d2d3d94
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
added a test that should fail with #102943 (see
|
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 13, 2022
…li-obk replace ReErased with fresh region vars in opaque types See inline comments. Prior art rust-lang#102943. cc `@compiler-errors` `@oli-obk` Fixes rust-lang#100267 Fixes rust-lang#101940 Fixes rust-lang#102649 Fixes rust-lang#102510
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 14, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103000 (Add suggestion to the "missing native library" error) - rust-lang#103006 (rustdoc: don't ICE on `TyKind::Typeof`) - rust-lang#103008 (replace ReErased with fresh region vars in opaque types) - rust-lang#103011 (Improve rustdoc `unsafe-fn` GUI test) - rust-lang#103013 (Add new bootstrap entrypoints to triagebot) - rust-lang#103016 (Ensure enum cast moves) - rust-lang#103021 (Add links to relevant pages to find constraint information) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See inline comments.
Prior art #102943. cc @compiler-errors @oli-obk
Fixes #100267
Fixes #101940
Fixes #102649
Fixes #102510