-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std lib build broken for uclibc #95866
Comments
@skrap can you figure out whether the problem is in libc or uclibc itself? |
Looks like @pfmooney has a good-looking PR out to add those accessors into libc! |
Add siginfo accessors for uclibc With rust-lang/rust#95688 switching to the libc-provided `si_addr()` accessor on `siginfo_t`, it became apparent that the uclibc target was lacking that implementation (see rust-lang/rust#95866). It would be nice to provide the same accessor in uclibc as the other UNIX-y platforms. CC: `@asomers` `@name1e5s` `@skrap` - If you have a testing env for this, could you try it out?
After the next release of libc, whenever that may be, the change from the now-integrated rust-lang/libc#2750 should help address this. A stopgap fix might be justified in the mean time. |
libc just released 0.2.124 , and I can build std for uclibc again. |
OK, so we just need to bump the libc version in rust. Unless someone objects, I'll submit a PR to rust later today to bump the libc version. |
bump libc version for uclibc fixes closes rust-lang#95866 The required functions have been added to libc in rust-lang/libc#2750. That change made it into libc 0.2.124, but this just takes the latest libc.
The libc version has been updated in #96510, closing as fixed. |
Commit 33fd73f appears to have broken the build for uclibc. This command fails:
The problem is that libc does not define that field for uclibc. Whether that's an oversight in libc, or whether uclibc itself doesn't define that field, I don't know.
The text was updated successfully, but these errors were encountered: