Use singular number for all feature names #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
features => feature users => user Neither of these features have yet been included in a release, so it's ok to rename them.
bors bot
added a commit
that referenced
this pull request
Apr 9, 2022
1694: Use singular number for all feature names r=rtzoeller a=asomers features => feature users => user Neither of these features have yet been included in a release, so it's ok to rename them. Co-authored-by: Alan Somers <[email protected]>
|
Build failed: |
|
Looks like rustc itself is broken for uclibc . rust-lang/rust@33fd73f . |
|
@asomers thanks for filing rust-lang/rust#95866. FYI @skrap. |
rtzoeller
reviewed
Apr 9, 2022
.cirrus.yml
Outdated
| @@ -289,6 +289,9 @@ task: | |||
| - name: Linux armv7 uclibceabihf | |||
| env: | |||
| TARGET: armv7-unknown-linux-uclibceabihf | |||
| # Pin nightly compiler due to | |||
| # https://github.com/rust-lang/rust/issues/95866 | |||
| TOOLCHAIN: nightly-2022-04-01 | |||
There was a problem hiding this comment.
I believe you also need the
setup_script:
- rustup target add $TARGET
- rustup toolchain install $TOOLCHAIN --profile minimal --target $TARGET
- rustup component add --toolchain $TOOLCHAIN clippy
bit.
asomers
force-pushed
the
user
branch
3 times, most recently
from
716890a
to
a5ca584
Compare
|
Ok, I think I got CI straightened out. |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
features => feature
users => user
Neither of these features have yet been included in a release, so it's
ok to rename them.