-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link error in rustc-main: undefined reference to `__floatundisf' #53916
Comments
When I compile a fresh clone with this config.toml, it works:
It does an LLVM compile and install while doing this. When I compile a fresh clone with this config.toml, I get the link error:
It doesn't do an LLVM compile and install. |
To clarify, the problem doesn't occur when I do this:
But it does happen when I do this:
|
I think this line may be incorrect. That says that on non-windows x86_64 we should use a C shim but we fail to compile the C shim! I believe this was a bug introduced in rust-lang/compiler-builtins#252 cc @dingelish |
@nnethercote I think I've fixed this on the master branch of compiler-builtins, can you try updating the |
@alexcrichton: I did the following:
With this, the submodule is on tip and I have your C shim patch. But then when I build with
which takes me back to the original |
rkruppe told me on IRC to set |
I've been bitten by this before when I created a new checkout of rustc. This setting completely overwrites any changes, even uncommited ones. Maybe we can change the default to |
@oli-obk perhaps, but we should discuss that its own issue rather than here most likely |
Fixes a mistake in using C shims to... Closes rust-lang#53916
I've opened #53969 to fix this |
…atsakis Update the compiler-builtins submodule Fixes a mistake in using C shims to... Closes #53916
…komatsakis Rewrite `precompute_borrows_out_of_scope` for fewer hash table lookups. It now does one hash table lookup per basic block, instead of one per statement. This is worthwhile because this function is hot for NLL builds of `ucd`. I haven't measured the effect of this yet because I'm having trouble doing optimized builds of rustc that are suitable for profiling (rust-lang#53916). I will do an online perf run instead. r? @nikomatsakis
…komatsakis Rewrite `precompute_borrows_out_of_scope` for fewer hash table lookups. It now does one hash table lookup per basic block, instead of one per statement. This is worthwhile because this function is hot for NLL builds of `ucd`. I haven't measured the effect of this yet because I'm having trouble doing optimized builds of rustc that are suitable for profiling (rust-lang#53916). I will do an online perf run instead. r? @nikomatsakis
I just updated to 763d91a and when building the compiler I get a link error on rustc-main:
This is on my Ubuntu 18.04 box, which is pretty ordinary and doesn't have anything special about it.
The text was updated successfully, but these errors were encountered: