Don't automatically update submodules when running x.py
#53970
Labels
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
x.py
#53970
#53916 (comment) noted that the
submodules
setting ofconfig.toml
is not very discoverable.I have set it to
false
in all my trees and update my submodules manually, because I've had work destroyed multiple times when I changed submodule contents andx.py
killed them without asking by force updating the submodule to the commit checked into the rustc repo.There are a few (not mutually exclusive) ways to improve this:
submodules = false
by default (might inconvenience developers that never touch submodules, I am biased here due to touching clippy and miri on a very regular basis)cc @nnethercote @rkruppe
The text was updated successfully, but these errors were encountered: