Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious failure in RLS tests #43453

Closed
alexcrichton opened this issue Jul 24, 2017 · 6 comments · Fixed by #43485
Closed

Spurious failure in RLS tests #43453

alexcrichton opened this issue Jul 24, 2017 · 6 comments · Fixed by #43485
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC

Comments

@alexcrichton
Copy link
Member

First seen on #43361 as https://ci.appveyor.com/project/rust-lang/rust/build/1.0.4048/job/8raxjkn064e3yimc, looks like:

running 14 tests
test server::test::server_message_get_method_name ... ok
test build::cargo::test::test_dedup_flags ... ok
test server::test::server_message_to_str ... ok
{"message":"cannot find struct, variant or union type `LibCfgTestStruct` in module `bin_lib_no_cfg_test`","code":{"code":"E0422","explanation":"\nYou are trying to use an identifier that is either undefined or not a struct.\nErroneous code example:\n\n```compile_fail,E0422\nfn main () {\n    let x = Foo { x: 1, y: 2 };\n}\n```\n\nIn this case, `Foo` is undefined, so it inherently isn't anything, and\ndefinitely not a struct.\n\n```compile_fail\nfn main () {\n    let foo = 1;\n    let x = foo { x: 1, y: 2 };\n}\n```\n\nIn this case, `foo` is defined, but is not a struct, so Rust can't use it as\none.\n"},"level":"error","spans":[{"file_name":"test_data\\bin_lib_no_cfg_test\\src\\main.rs","byte_start":130,"byte_end":146,"line_start":5,"line_end":5,"column_start":37,"column_end":53,"is_primary":true,"text":[{"text":"    let test = bin_lib_no_cfg_test::LibCfgTestStruct { };","highlight_start":37,"highlight_end":53}],"label":"not found in `bin_lib_no_cfg_test`","suggested_replacement":null,"expansion":null}],"children":[],"rendered":null}
test test::test_bin_lib_project_no_cfg_test ... ok
test test::test_bin_lib_project ... ok
test test::test_completion ... ok
test test::test_find_all_refs ... ok
test test::test_find_all_refs_no_cfg_test ... ok
test test::test_multiple_binaries ... ok
test test::test_parse_error_on_malformed_input ... ok
test test::test_reformat ... ok
test test::test_reformat_with_range ... ok
test test::test_simple_workspace ... ok
test test::test_borrow_error ... FAILED
failures:
---- test::test_borrow_error stdout ----
	thread 'test::test_borrow_error' panicked at 'Hit timeout', src\tools\rls\src\test\harness.rs:142:12
failures:
    test::test_borrow_error
test result: FAILED. 13 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

cc @rls

@alexcrichton alexcrichton added the A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) label Jul 24, 2017
@Mark-Simulacrum
Copy link
Member

Also hit this on Travis (same test) in #43430.

@nrc
Copy link
Member

nrc commented Jul 25, 2017

cc me

@nrc nrc mentioned this issue Jul 26, 2017
bors added a commit that referenced this issue Jul 26, 2017
Update RLS

This pulls in rust-lang/rls@79d659e It should fix #43453. It increases the timeout for test runs and forces builds in RLS tests to happen sequentially, this prevents interference between env vars passed to Cargo or rustc.

r? @Mark-Simulacrum
@SimonSapin
Copy link
Contributor

This is causing lots of CI failures. Should this test be disabled until a fix can be found?

@Mark-Simulacrum
Copy link
Member

We believe a fix is pending in #43485, once that lands we should be good to go.

@Mark-Simulacrum
Copy link
Member

I just saw this again, reopening...

@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Jul 28, 2017
@alexcrichton
Copy link
Member Author

These haven't shown up in quite some time, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants