Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the VSX and Altivec features on PowerPC #43419

Merged
merged 2 commits into from
Jul 25, 2017

Conversation

lu-zero
Copy link
Contributor

@lu-zero lu-zero commented Jul 23, 2017

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 23, 2017

📌 Commit bae663b has been approved by alexcrichton

@@ -0,0 +1,21 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use ".json" as the extension of this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I did not consider the fact there was a pull request open on the master branch when I pushed it...

@lu-zero
Copy link
Contributor Author

lu-zero commented Jul 24, 2017

Do you prefer having the intrinsics being added one by one or in a single commit ?

@carols10cents carols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 24, 2017
@alexcrichton
Copy link
Member

@bors: r+

Nah seems fine!

@bors
Copy link
Contributor

bors commented Jul 24, 2017

📌 Commit 9ed8cf8 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 24, 2017

⌛ Testing commit 9ed8cf8 with merge 49455b5eaa74c00473901d5408b4b993deb6095c...

@Mark-Simulacrum
Copy link
Member

@bors retry

Synchronized bors, and it forgot about this PR being tested...

@bors
Copy link
Contributor

bors commented Jul 25, 2017

⌛ Testing commit 9ed8cf8 with merge 8812b50ed8976e6abe810d4d104e531f6fe779cc...

@bors
Copy link
Contributor

bors commented Jul 25, 2017

💔 Test failed - status-travis

@lu-zero
Copy link
Contributor Author

lu-zero commented Jul 25, 2017

The failure seems unrelated to anything I touched with those two patches...

@Mark-Simulacrum
Copy link
Member

@bors retry

[01:21:51] 	thread 'test::test_bin_lib_project_no_cfg_test' panicked at 'Hit timeout', /checkout/src/tools/rls/src/test/harness.rs:142:12

@bors
Copy link
Contributor

bors commented Jul 25, 2017

⌛ Testing commit 9ed8cf8 with merge a643bdc...

bors added a commit that referenced this pull request Jul 25, 2017
Add support for the VSX and Altivec features on PowerPC
@bors
Copy link
Contributor

bors commented Jul 25, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a643bdc to master...

@bors bors merged commit 9ed8cf8 into rust-lang:master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants