-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the VSX and Altivec features on PowerPC #43419
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors: r+ |
📌 Commit bae663b has been approved by |
@@ -0,0 +1,21 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use ".json" as the extension of this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I did not consider the fact there was a pull request open on the master branch when I pushed it...
Do you prefer having the intrinsics being added one by one or in a single commit ? |
@bors: r+ Nah seems fine! |
📌 Commit 9ed8cf8 has been approved by |
⌛ Testing commit 9ed8cf8 with merge 49455b5eaa74c00473901d5408b4b993deb6095c... |
@bors retry Synchronized bors, and it forgot about this PR being tested... |
⌛ Testing commit 9ed8cf8 with merge 8812b50ed8976e6abe810d4d104e531f6fe779cc... |
💔 Test failed - status-travis |
The failure seems unrelated to anything I touched with those two patches... |
@bors retry
|
Add support for the VSX and Altivec features on PowerPC
☀️ Test successful - status-appveyor, status-travis |
No description provided.