Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multipart suggestions for raw string lints #11416

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

Alexendoo
Copy link
Member

@Alexendoo Alexendoo commented Aug 27, 2023

Should make it slightly easier to see the suggested edit

Before/after for needless_raw_string_hashes:

Before After
before after

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2023

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 27, 2023
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small nit, then we can r+ this :)

tests/ui/needless_raw_string.rs Show resolved Hide resolved
@xFrednet
Copy link
Member

xFrednet commented Sep 1, 2023

LGTM, thank you for the update :D

@bors r+

@bors
Copy link
Contributor

bors commented Sep 1, 2023

📌 Commit f595f1e has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 1, 2023

⌛ Testing commit f595f1e with merge a8b5245...

@bors
Copy link
Contributor

bors commented Sep 1, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing a8b5245 to master...

@bors bors merged commit a8b5245 into rust-lang:master Sep 1, 2023
4 checks passed
@Alexendoo Alexendoo deleted the raw-strings-multipart branch September 1, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants