Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move needless_raw_string_hashes to pedantic #11415

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Move needless_raw_string_hashes to pedantic #11415

merged 1 commit into from
Sep 28, 2023

Conversation

Alexendoo
Copy link
Member

@Alexendoo Alexendoo commented Aug 27, 2023 •
edited by xFrednet
Loading

IMO it doesn't improve code enough to be warn by default. It seems to be unclear to some also, but that can probably be remedied separately

changelog: Moved [needless_raw_string_hashes] to pedantic (Now allow-by-default)
#11415

r? @flip1995

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 27, 2023
@Centri3
Copy link
Member

Centri3 commented Aug 27, 2023

I'm fine with pedantic. Not sure what's wrong in #11402 though, as removing hashes should make no difference unless there's a " with that many or more hashes following it.

@Alexendoo
Copy link
Member Author

My guess is people are removing the r as well, I opened #11416 but didn't link the issue as being fixed by it since I think there's further improvements to be made/maybe there's something we're missing

@Alexendoo Alexendoo added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 29, 2023
@flip1995
Copy link
Member

Oh I completely missed this PR. Is this and the Backport still required with the other PR merged?

@flip1995
Copy link
Member

@bors r+

Reading through the issues, I figure this is required/wanted.

@bors
Copy link
Contributor

bors commented Sep 28, 2023

📌 Commit 1c77b0b has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 28, 2023

⌛ Testing commit 1c77b0b with merge 29ed6fa...

@bors
Copy link
Contributor

bors commented Sep 28, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 29ed6fa to master...

@bors bors merged commit 29ed6fa into rust-lang:master Sep 28, 2023
4 checks passed
@Alexendoo Alexendoo deleted the needless-raw-string-hashes-pedantic branch September 28, 2023 12:13
@flip1995
Copy link
Member

I'm leaning towards letting this change ride the release train without a backport. This lint is already in stable and I don't think the FN/confusion is so bad that we need a beta backport for this. However I'll cherry-pick this commit, so that it at least get's into 1.74.

@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Sep 28, 2023
@flip1995 flip1995 mentioned this pull request Sep 28, 2023
Merged
@flip1995
Copy link
Member

rust-lang/rust#116245

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 29, 2023
@matthiaskrgr
Rollup merge of rust-lang#116245 - flip1995:clippy-backport, r=Manish…
92234f9 
…earth

Clippy backport: Move needless_raw_string_hashes to pedantic

Really small backport this time. Context: rust-lang/rust-clippy#11415 (comment)

I'd rather get this in 1.74 than waiting another release cycle.

r? `@Manishearth`

cc `@Mark-Simulacrum` This should be merged before beta is branched tomorrow.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 29, 2023
@rust-timer
Unrolled build for rust-lang#116245
5a7f035 
Rollup merge of rust-lang#116245 - flip1995:clippy-backport, r=Manishearth

Clippy backport: Move needless_raw_string_hashes to pedantic

Really small backport this time. Context: rust-lang/rust-clippy#11415 (comment)

I'd rather get this in 1.74 than waiting another release cycle.

r? `@Manishearth`

cc `@Mark-Simulacrum` This should be merged before beta is branched tomorrow.
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Sep 30, 2023
@matthiaskrgr
Rollup merge of #116245 - flip1995:clippy-backport, r=Manishearth
d0ce5f2 
Clippy backport: Move needless_raw_string_hashes to pedantic

Really small backport this time. Context: rust-lang/rust-clippy#11415 (comment)

I'd rather get this in 1.74 than waiting another release cycle.

r? `@Manishearth`

cc `@Mark-Simulacrum` This should be merged before beta is branched tomorrow.
@xFrednet xFrednet removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 3, 2023
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Oct 6, 2023
@matthiaskrgr
Rollup merge of #116245 - flip1995:clippy-backport, r=Manishearth
1a82ca0 
Clippy backport: Move needless_raw_string_hashes to pedantic

Really small backport this time. Context: rust-lang#11415 (comment)

I'd rather get this in 1.74 than waiting another release cycle.

r? `@Manishearth`

cc `@Mark-Simulacrum` This should be merged before beta is branched tomorrow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centri3 Centri3 Centri3 approved these changes

Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Alexendoo @Centri3 @flip1995 @bors @xFrednet @rustbot