feat(wip): more robust autocomplete of self keyword in complete_fn_param #9575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
reviewed
Jul 18, 2021
| @@ -487,6 +489,8 @@ impl<'a> CompletionContext<'a> { | |||
| let for_is_prev2 = for_is_prev2(syntax_element.clone()); | |||
| (fn_is_prev && !inside_impl_trait_block) || for_is_prev2 | |||
| }; | |||
| // todo(jake): is this the right place to put this? | |||
| self.param_def = find_node_at_offset(&file_with_fake_ident, offset); | |||
There was a problem hiding this comment.
I think we can just replace the is_param field with the param_def and check for is_some where the former was used.
Assigning param_def should be done where is_param is assigned then.
Veykril
reviewed
Jul 18, 2021
| return None; | ||
| } | ||
|
|
||
| // todo: handle ampersand... somehow? |
|
Just a headsup, the tests for this module have moved in #9669 so you will have to do a rebase when you get back to this. |
|
Closing due to inactivity, feel free to reopen if you are making progress on this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip, based off of @Veykril's comments in #9548 for #9522.
things to do:
ctx.is_paramctx.param_def.no_completion_inside_fntest 🤔For the last item, is there any good example I can look at on how to do it? Also please let me know if this is what you had in mind!