-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete method self param declarations #9522
Comments
I'd propose we complete |
Fine with me. It would be interesting if we could offer impl Foo {
fn bar(self: <|>) {
}
} |
9548: add: Adding self keyword completion in complete_fn_param r=lnicola a=feniljain Solves #9522 I haven't added Arc<self> for now as there were some conflicting opinions on it Co-authored-by: vi_mi <[email protected]>
Is this issue resolved with #9548 merged? |
It isn't, that PR only added a very basic form of this. Basically it only works for functions with no parameters in them, see the comments after the merge in #9548 (comment) as well as #9575 |
Does this issue consider completing
self
like here:It'd be cool if this completed
self
,&self
,&mut self
,mut self
andself: Arc<Self>
Originally posted by @jhgg in #9311 (comment)
A simple implementation has been done in #9548 but this only works for empty parameterlists which is not too useful as typing
&
already doesn't offer any completions.The text was updated successfully, but these errors were encountered: