-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyedits to FFI and unwinding section #396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are minor changes that make the text flow better to me.
tmandry
commented
Jan 14, 2023
Who needs to review this? |
ehuss
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I assume you are done with the edits. It looks good to me, but if you want to make more changes, feel free to open another PR.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 31, 2023
Update books ## rust-lang/book 2 commits in 2cd1b5593d26dc6a03c20f8619187ad4b2485552..f2a78f64b668f63f581203c6bac509903f7c00ee 2023-01-23 18:19:32 UTC to 2023-01-23 15:15:22 UTC - Change CamelCase to UpperCamelCase - Fix broken link to the No Starch Press version (rust-lang/book#3513) ## rust-embedded/book 3 commits in 19f798d448835a4888e3b3eae7fe69f1d61d8681..f1a4614aa41cc544b91b79760a709e113f3451d7 2023-01-26 15:21:58 UTC to 2023-01-18 07:51:06 UTC - Fix typo in the registers.md (rust-embedded/book#343) - Macports install instructions (rust-embedded/book#342) - remove extern crate statements (rust-embedded/book#340) ## rust-lang/nomicon 2 commits in 960d610e7f33889a2577f5f17c26f0d5c82b30df..bd1829d235296952bf72ca55635e360584b8805e 2023-01-18 03:14:58 UTC to 2023-01-17 20:05:07 UTC - Copyedits to FFI and unwinding section (rust-lang/nomicon#396) - Fix typo in dropck documentation (rust-lang/nomicon#397) ## rust-lang/reference 2 commits in 2cb0ed9ba56360949f492f9866afe8c293f9f9da..22882fb3f7b4d69fdc0d1731e8b9cfcb6910537d 2023-01-23 13:21:28 UTC to 2023-01-20 18:38:44 UTC - Fix typo “assigment” (…and more) (rust-lang/reference#1322) - Syntax correction for trait-bounds.md (rust-lang/reference#1319) ## rust-lang/rust-by-example 1 commits in a9fb7d13eadfcc5f457962731f105b97f9a7474a..134376872e8c387ef369507e0ee9b5a0e3272718 2023-01-25 11:56:37 UTC to 2023-01-25 11:56:37 UTC - update std_misc/file/create.md: fixed grammar (rust-lang/rust-by-example#1668) ## rust-lang/rustc-dev-guide 12 commits in 7352353ae91c48b136d2ca7d03822e1448165e1e..e359ee27fc3da3356d71a732128c0a1abe02e53a 2023-01-30 15:08:16 UTC to 2023-01-17 12:44:19 UTC - New infcx usage (rust-lang/rustc-dev-guide#1571) - Create a chapter for AST validation (rust-lang/rustc-dev-guide#1524) - Use ephemeral PAT for linkcheck (rust-lang/rustc-dev-guide#1569) - add section for the new trait solver (rust-lang/rustc-dev-guide#1551) - version 5 is now not supported (rust-lang/rustc-dev-guide#1568) - there are still no locale bundles (rust-lang/rustc-dev-guide#1567) - bumpt date-check examples to current month (rust-lang/rustc-dev-guide#1566) - Update hir.md (rust-lang/rustc-dev-guide#1565) - rustc_typeck exists no more (rust-lang/rustc-dev-guide#1559) - Correct tests misplacement (rust-lang/rustc-dev-guide#1564) - Update resolution.md (rust-lang/rustc-dev-guide#1561) - Update asm.md (rust-lang/rustc-dev-guide#1560)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are minor changes that make the text flow better to me.
cc #365