Update to highlight.js 9.10.0 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
|
@azerupi is happy, Travis is happy, and so I am happy. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eddyb noticed some weird things being highlighted in the book, which led to him sending this PR to highlight.js, which has made it into highlight.js 9.10.0, which has led to me sending in this pr :)
I generated the js using this page and choosing the same languages that were listed in this pr.
I also updated highlight.css using the Atelier Dune Light Theme that comes with highlight.js, since that's what the comment at the top seemed to indicate.... there's a lot in the diff though, and atelier dune light doesn't seem to change very often but it has changed a little, soooo i'm not sure how much change is due to the "modifications" since it was introduced as modified. I tried to keep what looked important, and I definitely kept the gray background of code blocks because it tried to change it to yellow 😂😂😂 Please let me know if there's anything in particular I should put back the way it was!
It looks pretty good trying it out locally on the book, wdyt?