Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When highlight.js cuts a version > 9.9.0, send a PR to mdbook #453

Closed
carols10cents opened this issue Feb 19, 2017 · 1 comment
Closed

When highlight.js cuts a version > 9.9.0, send a PR to mdbook #453

carols10cents opened this issue Feb 19, 2017 · 1 comment
Assignees
@carols10cents
Labels
blocked upstream Blocked on a change that needs to happen in a different repo first

Comments

@carols10cents
Copy link
Member

eddyb sent an update to fix some rust highlighting to highlight.js, and it's merged, but idk when there'll be a new release. This is an issue to remind me to check that every once in a while and, when there is a new release, send a PR to the vendored highlight.js in mdbook so that we can take advantage of that here.
@carols10cents carols10cents self-assigned this Feb 19, 2017
@carols10cents carols10cents added the blocked upstream Blocked on a change that needs to happen in a different repo first label Feb 19, 2017
@carols10cents
Copy link
Member Author

PR sent, so I'm closing this :) https://github.com/azerupi/mdBook/pull/225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carols10cents carols10cents

Labels
blocked upstream Blocked on a change that needs to happen in a different repo first
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carols10cents