Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FreeBSD's CAP_UNUSED* and CAP_ALL* constants #4184

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Dec 8, 2024

They aren't stable across OS versions and don't have any legitimate use in applications.

See #4183 for the corresponding change to the libc-0.2 branch.

Description

Remove unstable and non-useful definitions

Sources

This commit, for example, changed some of these constants in FreeBSD 15.

freebsd/freebsd-src@b165e9e

I was unable to find any applications using these constants with Github code search. Only libraries like this one that supplied bindings. I also audited every open source consumer of the capsicum-rs crate to ensure that none were using these constants.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

They aren't stable across OS versions and don't have any legitimate use
in applications.

See rust-lang#4183 for the corresponding
change to the libc-0.2 branch.
@rustbot
Copy link
Collaborator

rustbot commented Dec 8, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@asomers
Copy link
Contributor Author

asomers commented Dec 8, 2024

I think the failure on aarch64-linux-android is unrelated.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

@tgross35 tgross35 added this pull request to the merge queue Dec 8, 2024
Merged via the queue into rust-lang:main with commit 770abef Dec 8, 2024
45 checks passed
@asomers asomers deleted the cap-unused-main branch December 9, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants