[0.2] Deprecate FreeBSD's CAP_UNUSED* and CAP_ALL* constants #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They aren't stable across OS versions, and they don't have any legitimate use in applications.
|
I audited all of the consumers of the capsicum-rs crate. None of them use these constants, and they all build OK with a patched libc. For the main branch, I think we can simply delete these constants. |
|
CI is failing because this branch needs #4177 . |
asomers
added a commit
to asomers/libc
that referenced
this pull request
Dec 8, 2024
They aren't stable across OS versions and don't have any legitimate use in applications. See rust-lang#4183 for the corresponding change to the libc-0.2 branch.
This was referenced Dec 8, 2024
tgross35
approved these changes
Dec 8, 2024
tgross35
changed the title
Merged
|
Applied via #4187. Not sure why GH didn't close this PR but this should be all set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They aren't stable across OS versions, and they don't have any legitimate use in applications.
Description
Deprecate constants that are unstable and not useful to our consumers
Sources
This commit, for example, changed some of these constants in FreeBSD 15.
freebsd/freebsd-src@b165e9e
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI