refactor(toml): Make manifest file layout more consitent #12768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The theory of organization - Built-in impls first (`Display` in this case) - `Serialize` next to `Display` since they are related
At minimum, we should have "everything" for a type next to it but it was previously scattered. When collecting the related impl's, I decided to order based on how I tend to do it. Generally the methods are the "core" of the type so I put those first. The order I went with 1. Basic impl body 2. Complex impl body 3. Trait impls 4. Helper free-functions
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-manifest
weihanglo
approved these changes
Oct 4, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Oct 4, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This is to make the file easier to browse (to me) as I work to split out the file format from the business logic to explore ideas for how we could split out a manifest crate (see #12801).
How should we test and review this PR?
This is just moving code around, so existing tests should be sufficient.
This does try to break up the refactors by theme to make it slightly easier.
If there are ideas for further improvements, that might be best left for future refactors rather than cramming every possible idea in this one.
Additional information