Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(toml): Make manifest file layout more consitent #12768

Merged
merged 3 commits into from
Oct 4, 2023
Merged

refactor(toml): Make manifest file layout more consitent #12768

merged 3 commits into from
Oct 4, 2023

Commits on Oct 2, 2023

  1. refactor(toml): Consistently lay out fmt/serde impls 

    The theory of organization
- Built-in impls first (`Display` in this case)
- `Serialize` next to `Display` since they are related
    @epage
    epage committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    e476251 View commit details
    Browse the repository at this point in the history

  2. refactor(toml): Move impl bodies next to types 

    At minimum, we should have "everything" for a type next to it but it was
previously scattered.

When collecting the related impl's, I decided to order based on how I
tend to do it.  Generally the methods are the "core" of the type so I
put those first.

The order I went with
1. Basic impl body
2. Complex impl body
3. Trait impls
4. Helper free-functions
    @epage
    epage committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    b784baf View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. refactor(toml): Move related structs next to each other

    @epage
    epage committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    571e6cf View commit details
    Browse the repository at this point in the history