Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds simple single producer, single consumer crossbeam channel example. #551

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

j-haj
Copy link
Contributor

@j-haj j-haj commented Oct 1, 2019

Part of tracking issue #440. This adds a simple message passing example with two threads.

Copy link
Collaborator

@AndyGauge AndyGauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the hard work.

@j-haj
Copy link
Contributor Author

j-haj commented Oct 2, 2019

@AndyGauge do we know why the percent_encoding example is failing? I noticed this locally but it seemed somewhat flaky.

Edit nevermind, I see #542 is addressing this issue

@AndyGauge
Copy link
Collaborator

AndyGauge commented Oct 2, 2019

It's nightly only problem and it has to do with the way skeptic reads rlibs which is way above my capabilities. That's diving into the internals, consuming a non-public API. I was looking at rolling back the percent-encoding example but that attempt failed too. If you can figure out a way to get tests to pass I bet I'd approve the PR
Edit: looks like rust 1.38 introduced the problem, so its now on stable too.

@AndyGauge AndyGauge merged commit 084f51c into rust-lang-nursery:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants