Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependent crates with lesser versions are being used by rust-skeptic #542

Closed
AndyGauge opened this issue Aug 23, 2019 · 4 comments · Fixed by #600
Closed

Dependent crates with lesser versions are being used by rust-skeptic #542

AndyGauge opened this issue Aug 23, 2019 · 4 comments · Fixed by #600

Comments

@AndyGauge
Copy link
Collaborator

6 | use rand::distributions::Alphanumeric;

| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no Alphanumeric in distributions

error[E0599]: no method named sample found for type rand::ThreadRng in the current scope

--> /tmp/rust-skeptic.lV2m9aQedOqB/test.rs:13:29

|

13 | *p = (0..5).map(|_| rng.sample(&Alphanumeric)).collect()

| ^^^^^^

5 | use rand::distributions::{Distribution, Uniform};

| ^^^^^^^^^^^^ ^^^^^^^ no Uniform in distributions

| |

| no Distribution in distributions

warning: unused import: Rng

--> /tmp/rust-skeptic.NnKO8W2SxQw2/test.rs:4:24

|

4 | use rand::{thread_rng, Rng};

| ^^^

|

= note: #[warn(unused_imports)] on by default

error[E0599]: no method named sample_iter found for type rand::ThreadRng in the current scope

--> /tmp/rust-skeptic.NnKO8W2SxQw2/test.rs:9:10

|

9 | .sample_iter(&Alphanumeric)

|

@AndyGauge
Copy link
Collaborator Author

AndyGauge commented Sep 19, 2019

I've determined that nightly is picking up the build-dependency skeptic having tempdir having rand 4 as a dependency and using an older version (not a newer one like previously thought). Could be a bug in the rust-skeptic internals.

@AndyGauge AndyGauge changed the title Check rand crate for changes. Nightly using wrong rand version. Sep 19, 2019
@AndyGauge AndyGauge mentioned this issue Sep 19, 2019
11 tasks
@AndyGauge
Copy link
Collaborator Author

Looks like tempdir is deprecated in favor of tempfile (which uses rand 0.7). I'm going to fork skeptic and try and make it work with tempfile.

@AndyGauge
Copy link
Collaborator Author

AndyGauge commented Sep 19, 2019

now its percent-encoding! Submitted budziq/rust-skeptic#111 for investigation

@AndyGauge AndyGauge changed the title Nightly using wrong rand version. Dependent crates with lesser versions are being used by rust-skeptic Sep 19, 2019
@AndyGauge
Copy link
Collaborator Author

Currently we are working around this issue by ignoring the nondeterministic failures.

@AndyGauge AndyGauge mentioned this issue Apr 14, 2020
11 tasks
@AndyGauge AndyGauge mentioned this issue Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant