-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run() -> main() #548
run() -> main() #548
Conversation
Glad you addressed it, having this old way of doing things in a reference that helps newcomers is a bad idea. I'm going to try to fix the build failure in master and then look to merge this. |
Both of the issues are on nightly. I believe my other PR fixes the sole failure on the Mac build, and that of the Xenial issues, only one is maybe introduced by this PR. They all seem to deal with the rand crate. |
#542 |
That didn't fix it. There is something really strange going on here. |
I started experimenting a little with things here. |
I was able to fork rust-skeptic and replace the tempdir with tempfile, so there is no rand < .5 references, did a cargo clean and cargo build and cargo test and still get the behavior. |
Taking postgres out of the cargo.toml file fixes the error lol |
Ah, I'll revert my last few commits then. |
I'm working on a pr that removes tempdir as well because I think they both need to be nixed. Thank you so much for looking into this! |
d5b694f
to
e7c3aef
Compare
Do you want to resolve the merge conflict in src/web/clients/download/basic.md ? |
e7c3aef
to
203f4da
Compare
Just did. |
Aaaand I broke master. I'm going to merge this and will work on the failures later today. |
R I P master |
Duplicates #441 due to that PR being dead. Fixes #433.
I rebased sepiropht's work into this branch rather than reimplement it myself, and made my own changes to implement the remaining fixes as a separate commit. For this reason, there are two commits in my PR, defying the usual convention for rust-cookbook. It seemed worthwhile to open a new PR including their work since their update is very important for this repo being current and useful.
I did not address gratuitous error-chain usage because that seems like a separate concern. I left a few cases where run() was not being used as an entry point but rather a local function untouched, because it is syntactically valid, even if it is awkward and somewhat dated in style: they can be fixed later.
Checked Before PR Opened:
cargo test
mdbook serve -o
./ci/spellchecker.sh
link-checker ./book
ishhttps://docs.rs/tar/*/tar/struct.Entry.html
To Check After PR Opens: