-
Notifications
You must be signed in to change notification settings - Fork 137
failure_derive won't build with quote 1.0.3 #342
Comments
Same issue in my crates, with the same version of failure_derive too (github.com-1ecc6299db9ec823/failure_derive-0.1.6). |
same issue here |
1 similar comment
same issue here |
I asked in the Rust Discord channel on how to pin a version for all dependencies until the fix is deployed. In Your Cargo.toml |
Admittedly, this is not "quotes fault", but the blowout from failure_derive breakage is substantial, and quote 1.0.3 should probably be YANK'd to stop the bleeding. This reverts commit 4154389. See also: * withoutboats/failure_derive#13 * rust-lang-deprecated/failure#343 * rust-lang-deprecated/failure#342
Temporary workaround for rust-lang-deprecated/failure#342.
Do you think we could get this shipped as a point release to crates.io soonish as we're going to get widespread ecosystem breakages without this PR @mitsuhiko ? |
The idea to use |
@wdanilo |
@est31 Thank you. By the way, do you know if there is any way to add |
See rust-lang-deprecated/failure#342 gstreamer/gst-build#83
Yeah, I’ll merge the associated PR and release it to crates.io when I’m in the office within an hour. |
@est31 Actually I realized this solution does not work. The problem is that |
Can you just add quote=“=1.0.2” in the dependencies as a stopgap? (Or maybe quote=“<=1.0.2” might be a bit kinder) |
@gilescope I tried it. If you will have a free minute, I would be thankful if you could take a look here: enso-org/ide#234 (commit e7afd7e). It seems that the version was not picked up as it was still isntlaling |
I've opened a PR to release a fix for this issue: #345. |
New version of failure crate is just being published so hang on 30 mins and your problems will disappear Sent with GitHawk |
failure v0.1.7 and failure_derive v0.1.7 have just been published. |
Works thank you |
My CI builds just started failing with the following error:
Looks like the
quote
crate renamed__rt
to__private
in its1.0.3
release that just came out: dtolnay/quote@4154389The text was updated successfully, but these errors were encountered: