Skip to content
This repository has been archived by the owner on Aug 16, 2021. It is now read-only.

failure_derive won't build with quote 1.0.3 #342

Closed
turboladen opened this issue Mar 5, 2020 · 16 comments · Fixed by #343 or #345
Closed

failure_derive won't build with quote 1.0.3 #342

turboladen opened this issue Mar 5, 2020 · 16 comments · Fixed by #343 or #345

Comments

@turboladen
Copy link

turboladen commented Mar 5, 2020

My CI builds just started failing with the following error:

error[E0433]: failed to resolve: could not find `__rt` in `quote`
   --> /Users/sloveless/.cargo/registry/src/github.com-1ecc6299db9ec823/failure_derive-0.1.6/src/lib.rs:107:70
    |
107 | fn display_body(s: &synstructure::Structure) -> Result<Option<quote::__rt::TokenStream>, Error> {
    |                                                                      ^^^^ could not find `__rt` in `quote`

Looks like the quote crate renamed __rt to __private in its 1.0.3 release that just came out: dtolnay/quote@4154389

@Masterchef365
Copy link

Same issue in my crates, with the same version of failure_derive too (github.com-1ecc6299db9ec823/failure_derive-0.1.6).

@patrickelectric
Copy link

same issue here

1 similar comment
@yiblet
Copy link

yiblet commented Mar 5, 2020

same issue here

@normano
Copy link

normano commented Mar 5, 2020

I asked in the Rust Discord channel on how to pin a version for all dependencies until the fix is deployed.

In Your Cargo.toml
quote = "=1.0.2"

kentfredric added a commit to kentfredric/quote that referenced this issue Mar 5, 2020
Admittedly, this is not "quotes fault", but the blowout from
failure_derive breakage is substantial, and quote 1.0.3 should
probably be YANK'd to stop the bleeding.

This reverts commit 4154389.

See also:
* withoutboats/failure_derive#13
* rust-lang-deprecated/failure#343
* rust-lang-deprecated/failure#342
qryxip added a commit to qryxip/cargo-udeps that referenced this issue Mar 5, 2020
qryxip added a commit to qryxip/cargo-udeps that referenced this issue Mar 5, 2020
tesaguri added a commit to tesaguri/oauth1-request-rs that referenced this issue Mar 5, 2020
@gilescope
Copy link

gilescope commented Mar 5, 2020

Do you think we could get this shipped as a point release to crates.io soonish as we're going to get widespread ecosystem breakages without this PR @mitsuhiko ?

@wdanilo
Copy link

wdanilo commented Mar 5, 2020

The idea to use quote = "=1.0.2" is not working for us as this package is not our dependency. Right now doing cargo install wasm-pack fails, which is a 3rd-party binary for us. Is there any way to change in Rust the dependency version of a binary that we install with cargo install ?

@est31
Copy link

est31 commented Mar 5, 2020

@wdanilo cargo install wasm-pack --locked should do it.

@wdanilo
Copy link

wdanilo commented Mar 5, 2020

@est31 Thank you. By the way, do you know if there is any way to add quote = "=1.0.2" only to cargo.lock, as this is not our dependency and I dont want do add artificial deps to cargo.toml?

@davidbarsky
Copy link
Contributor

Yeah, I’ll merge the associated PR and release it to crates.io when I’m in the office within an hour.

@wdanilo
Copy link

wdanilo commented Mar 5, 2020

@est31 Actually I realized this solution does not work. The problem is that cargo install wasm-pack --locked does take into consideration the Cargo.lock file, but it contains locks for our packages, not 3rd party binaries, so still the same error appears.

@gilescope
Copy link

gilescope commented Mar 5, 2020

Can you just add quote=“=1.0.2” in the dependencies as a stopgap?

(Or maybe quote=“<=1.0.2” might be a bit kinder)

@wdanilo
Copy link

wdanilo commented Mar 5, 2020

@gilescope I tried it. If you will have a free minute, I would be thankful if you could take a look here: enso-org/ide#234 (commit e7afd7e). It seems that the version was not picked up as it was still isntlaling 1.0.3

@davidbarsky
Copy link
Contributor

I've opened a PR to release a fix for this issue: #345.

@gilescope
Copy link

New version of failure crate is just being published so hang on 30 mins and your problems will disappear

Sent with GitHawk

@davidbarsky
Copy link
Contributor

failure v0.1.7 and failure_derive v0.1.7 have just been published.

@kalch
Copy link

kalch commented Mar 5, 2020

Works thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
10 participants