Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Temporarily use a patched version of failure crate #2754

Closed
wants to merge 1 commit into from

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Mar 5, 2020

This fixes an issue in the failure crate which used a private name from the quote crate which was removed in version 1.0.3+.

For more details, see:

@Yawning
Copy link
Contributor

Yawning commented Mar 5, 2020

File a follow up issue to remove the use of the failure crate (https://users.rust-lang.org/t/failure-derive-compilation-error/39062/14) please.

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #2754 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2754      +/-   ##
==========================================
+ Coverage   62.74%   62.78%   +0.03%     
==========================================
  Files         384      384              
  Lines       36258    36258              
==========================================
+ Hits        22749    22763      +14     
+ Misses      10616    10599      -17     
- Partials     2893     2896       +3     
Impacted Files Coverage Δ
go/worker/common/p2p/p2p.go 67.56% <0.00%> (-3.61%) ⬇️
go/storage/metrics.go 72.64% <0.00%> (-2.57%) ⬇️
go/storage/api/root_cache.go 70.11% <0.00%> (-2.30%) ⬇️
go/storage/database/database.go 74.56% <0.00%> (-1.76%) ⬇️
go/common/grpc/grpc.go 77.59% <0.00%> (-1.25%) ⬇️
go/storage/client/client.go 75.63% <0.00%> (-0.85%) ⬇️
go/worker/registration/worker.go 66.34% <0.00%> (-0.49%) ⬇️
go/worker/compute/merge/committee/node.go 75.62% <0.00%> (+0.24%) ⬆️
go/consensus/tendermint/tendermint.go 67.35% <0.00%> (+0.41%) ⬆️
go/storage/mkvs/urkel/iterator.go 85.62% <0.00%> (+1.25%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8079357...a5f7f1a. Read the comment docs.

@tjanez
Copy link
Member Author

tjanez commented Mar 5, 2020

We can also wait since a new version of failure with the fix is said to be released in an hour:
rust-lang-deprecated/failure#342 (comment)

@tjanez tjanez changed the title rust: Temporarily use a patched version of failure create rust: Temporarily use a patched version of failure crate Mar 5, 2020
@tjanez
Copy link
Member Author

tjanez commented Mar 5, 2020

File a follow up issue to remove the use of the failure crate (https://users.rust-lang.org/t/failure-derive-compilation-error/39062/14) please.

Done: #2755.

This fixes an issue in the failure crate which used a private name from
the quote crate which was removed in version 1.0.3+.

For more details, see:
- https://users.rust-lang.org/t/failure-derive-compilation-error/39062
- rust-lang-deprecated/failure#343
@tjanez tjanez force-pushed the tjanez/fix/rust-failure-public-tokenstream branch from c80656d to a5f7f1a Compare March 5, 2020 15:09
@tjanez
Copy link
Member Author

tjanez commented Mar 6, 2020

Closing since the upstream merged the fix and published the 0.1.7 release: https://crates.io/crates/failure/0.1.7.

@tjanez tjanez closed this Mar 6, 2020
@tjanez tjanez deleted the tjanez/fix/rust-failure-public-tokenstream branch March 6, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants